Changes variables named unit to 'iunit'
#1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in mpp_memutils.F90
…ls/include/axis_utils2.inc
…in data_override/include/data_override.inc
…_overlaps_fold_south, and set_single_overlap in mpp/include/mpp_domains_define.inc
… mpp/include/mpp_domains_misc.inc
…in mpp/include/mpp_io_misc.inc
…4D (2D to 4D for mpp_read_region) real arrays (KIND = 4 or 8), mpp_read_text, mpp_reat_meta, and mpp_get_tavg_info in mpp/include/mpp_io_read.inc
…as variable names in mpp/include/mpp_io_util.inc
…mes in mpp/include/mpp_io_write.inc
…riables in mpp/include/mpp_read_2Ddecomp.fh
…name in mpp/include/mpp_read_compressed.fh
…lude/mpp_read_distributed_ascii.fh
…name in mpp/include/mpp_write_2Ddecomp.fh
…name in mpp/include/mpp_write_compressed.fh
…name in test_fms/
…e in sat_vapor_pres/include/sat_vapor_pres.inc
abrooks1085
requested review from
thomas-robinson,
bensonr and
rem1776
as code owners
bensonr
previously approved these changes
Oct 19, 2023
|
We discussed leaving the old IO alone because it is deprecated anyway, making these changes complicates things, and we said we weren't going to update it. |
rem1776
approved these changes
Oct 27, 2023
rem1776
previously approved these changes
Nov 2, 2023
|
@thomas-robinson and @bensonr can you review this PR? |
|
@abrooks1085 - I think we need to address the issues raised by @rem1776 and @thomas-robinson |
bensonr
reviewed
Nov 13, 2023
bensonr
approved these changes
Nov 13, 2023
rem1776
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
unitis a keyword that is used by Fortran to specify the logical unit associated with a file. In FMS,unitis often used as a variable name to store the value of this logical unit. This PR suggests changes to this variable name fromunittoiunit, and does not include any directories/modules that are either no longer used and/or deprecated.Fixes #1328
How Has This Been Tested?
autotools with gcc/13.1.0, netcdf/4.9.2, mpich/4.1.2, hdf5/1.14.1-2, libyaml/0.2.5
Checklist:
make distcheckpasses