Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated io options to build systems and CI #1063

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Oct 31, 2022

Description
Adds a --enable-deprecated-io configure flag to autotools and -DUSE_DEPRECATED_IO option to cmake that will be needed for compilation of the old io modules after the ifdef update. Also skips the mpp_io tests when used and updates CI to add that option to the matrix.

How Has This Been Tested?
tested with cmake/autoconf on the amd box

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 marked this pull request as draft October 31, 2022 17:00
@rem1776 rem1776 marked this pull request as ready for review October 31, 2022 17:30
@thomas-robinson
Copy link
Member

Why aren't the checks running?

@rem1776
Copy link
Contributor Author

rem1776 commented Nov 2, 2022

Why aren't the checks running?

It changed the required jobs since it adds in the io flag to the options matrix. It's just showing the old required ones, they'll need to be changed in the settings so we can merge this in.

Copy link
Member

@thomas-robinson thomas-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mark the tests to removal since we no longer support them

@rem1776 rem1776 merged commit 8c73bd1 into NOAA-GFDL:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants