mixed precision mosaic2 #1074
Merged
mixed precision mosaic2 #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlee03
requested review from
bensonr,
thomas-robinson and
rem1776
as code owners
mcallic2
approved these changes
Dec 8, 2022
rem1776
requested changes
Dec 8, 2022
mosaic2/include/grid2.fh
Outdated
| !* License along with FMS. If not, see <http://www.gnu.org/licenses/>. | ||
| !*********************************************************************** | ||
|
|
||
| !> @file |
There was a problem hiding this comment.
have you tried generating the doc site for this btw? I would think this file needs @addtogroup but since you put those in the .inc instead it might be fine.
There was a problem hiding this comment.
I'll add this to the *.fh files
mosaic2/include/grid2.inc
Outdated
| end select | ||
| end select | ||
| call get_grid_size_for_one_tile(component, tile, nlon, nlat) | ||
| valid_types = .true. |
There was a problem hiding this comment.
you can get rid of the valid_types variable, it was only added as a easy way to error out if the types don't match up.
There was a problem hiding this comment.
good catch, this one must have slipped
|
@rem1776, some of the fh files could get very long. It would be more organized and easier for future development if they were in separate files, that's my take on it... |
mcallic2
approved these changes
May 26, 2023
added 15 commits
July 24, 2023 13:53
mcallic2
approved these changes
Aug 31, 2023
rem1776
added a commit
that referenced
this pull request
Oct 6, 2023
* mixed precision column_diagnostics (#1076) * mixed precision mosaic2 (#1074) * mixed precision topography unit tests (#1364) * mixed precision tridiagonal (#1363) * mixed precision: add test for coupler_types and data_override changes (#1361) * Mixed precision `amip_interp_mod` (#1365) BREAKING CHANGE: Several variables and arrays which were previously public have been made private. These variables and arrays are not used in ice_amip or ocean_amip. amip_interp_type(r4_kind) and amip_interp_type(r8_kind) should be used for r4_kind and r8_kind precision, respectively. amip_interp_type without a kind parameter defaults to r8_kind. Co-authored-by: rem1776 <Ryan.Mulhall@noaa.gov> Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov> Co-authored-by: Caitlyn McAllister <65364559+mcallic2@users.noreply.github.com> Co-authored-by: Jesse Lentz <42011922+J-Lentz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this Pull Request,
mosaic2has been edited to as part of the mixed-mode project in FMSHow Has This Been Tested?
make and make check passes with
IntelandGCCChecklist:
make distcheckpasses