mixed precision sat_vapor_pressure #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlee03
requested review from
rem1776,
thomas-robinson and
bensonr
as code owners
mcallic2
suggested changes
Jan 6, 2023
mcallic2
approved these changes
Jan 17, 2023
added 6 commits
January 24, 2023 10:16
|
Closing this PR, this PR contains mixedmode include files for each FMS directory. Will open a separate PR that will not include the include file so that it can go into main. |
added 8 commits
March 13, 2023 09:55
mcallic2
approved these changes
Mar 24, 2023
added 4 commits
March 24, 2023 15:00
mcallic2
approved these changes
Mar 27, 2023
J-Lentz
reviewed
Mar 29, 2023
J-Lentz
reviewed
Mar 29, 2023
J-Lentz
reviewed
Mar 29, 2023
J-Lentz
reviewed
Mar 29, 2023
| x = -9.09718*(TBASI/tem(i)-1.0) - 3.56654*log10(TBASI/tem(i)) & | ||
| +0.876793*(1.0-tem(i)/TBASI) + log10(ESBASI) | ||
| esice =10.**(x) | ||
| x = -9.09718_lkind*(TBASI/tem(i)-one) & |
J-Lentz
reviewed
Mar 29, 2023
| endif | ||
| if (present (esat)) then | ||
| esat = -999. | ||
| esat = -999.0_lkind | ||
| endif | ||
| endif ! (nbad = 0) | ||
|
|
||
|
|
J-Lentz
reviewed
Mar 29, 2023
J-Lentz
approved these changes
Mar 29, 2023
thomas-robinson
approved these changes
Mar 29, 2023
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 25, 2023
rem1776
added a commit
that referenced
this pull request
Jun 2, 2023
…re, and fms_mod (#1239) * feat: mixed precision axis_utils2 (#1104) * feat: mixed precision fms_mod (#1147) * feat: horiz interp mixed precision (#1067) * mixed precision sat_vapor_pressure (#1095) * feat: add mixed precision axis_utils unit tests (#1172) * fix: move type definitions to before first usage to fix nvhpc bug (#1187) * fix: change allocatable type for intel errors (#1221) Co-authored-by: Caitlyn McAllister <65364559+mcallic2@users.noreply.github.com> Co-authored-by: Jesse Lentz <42011922+J-Lentz@users.noreply.github.com> Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com>
rem1776
added a commit
that referenced
this pull request
Jun 16, 2023
…re, and fms_mod (#1239) (#1258) * feat: mixed precision axis_utils2 (#1104) * feat: mixed precision fms_mod (#1147) * feat: horiz interp mixed precision (#1067) * mixed precision sat_vapor_pressure (#1095) * feat: add mixed precision axis_utils unit tests (#1172) * fix: move type definitions to before first usage to fix nvhpc bug (#1187) * fix: change allocatable type for intel errors (#1221) Co-authored-by: Caitlyn McAllister <65364559+mcallic2@users.noreply.github.com> Co-authored-by: Jesse Lentz <42011922+J-Lentz@users.noreply.github.com> Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this Pull Request,
sat_vapor_preshas been edited to as part of the mixed-mode project in FMS. The changes here include removal of all unlimited polymorphic variables (i.eclass(*)) in this module.How Has This Been Tested?
make and make check passes with Intel and GCC
Checklist:
make distcheckpasses