Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class(*) back to mixedmode diag_manager #1123

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

mlee03
Copy link
Contributor

@mlee03 mlee03 commented Jan 30, 2023

Description
All class(*) related code in FMS has been removed including diag_manager for the mixed-mode work. This leads to model compilation errors. Thus in this PR, class(*) related code has been added back todiag_manager in the mixedmode branch.

Fixes # (issue)

How Has This Been Tested?
FMS compiles with Intel

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@thomas-robinson
Copy link
Member

Does this merge with the dmUpdate branch?

@mlee03
Copy link
Contributor Author

mlee03 commented Jan 30, 2023

@thomas-robinson Marvelous news, it does! We'll make sure to keep it that way too.

@thomas-robinson
Copy link
Member

@thomas-robinson Marvelous news, it does! We'll make sure to keep it that way too.

...and the tests pass? Can you create a new PR in dmUpdate so we can look at the differences on here?

@rem1776 rem1776 merged commit 2456a41 into NOAA-GFDL:mixedmode Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants