Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -DPORTABLE_KINDS option to autotools and cmake build system #1572

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

mlee03
Copy link
Contributor

@mlee03 mlee03 commented Aug 13, 2024

Description
In this PR,

configure.ac file has been modified to accept --enable-portable-kinds argument during configuration.
This option will define -DPORTABLE_KINDS=1 for compilation and FMS variables will be compiled with iso_c_binding kind parameters.

The same change has been made to CMakeLists.txt where users can supply the argument -DPORTABLE_KINDS=on to cmake

Fixes #1571

How Has This Been Tested?
FMS compiles with -DPORTABLE_KINDS=1 when ./configure --enable-portable-kinds with gcc on the amdbox.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

rem1776
rem1776 previously approved these changes Aug 13, 2024
@bensonr
Copy link
Contributor

bensonr commented Aug 13, 2024

@mlee03 - please make these same changes to the CMake build system as well

@mlee03
Copy link
Contributor Author

mlee03 commented Aug 13, 2024

@bensonr, made the changes for cmake!

@mlee03 mlee03 changed the title Add --enable-portable-kinds option to configure Add -DPORTABLE_KINDS option to autotools and cmake build Aug 13, 2024
@mlee03 mlee03 changed the title Add -DPORTABLE_KINDS option to autotools and cmake build Add -DPORTABLE_KINDS option to autotools and cmake build system Aug 13, 2024
@rem1776 rem1776 merged commit 53c55b4 into NOAA-GFDL:main Aug 27, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autotools option to compile with PORTABLE_KINDS
3 participants