Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade solid-js from 1.7.12 to 1.8.7 #97

Closed
wants to merge 1 commit into from

Conversation

NOXITB
Copy link
Owner

@NOXITB NOXITB commented Dec 28, 2023

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to upgrade solid-js from 1.7.12 to 1.8.7.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 11 versions ahead of your current version.
  • The recommended version was released a month ago, on 2023-12-01.
Release notes
Package name: solid-js
  • 1.8.7 - 2023-12-01
  • 1.8.6 - 2023-11-22
  • 1.8.5 - 2023-10-30
    No content.
  • 1.8.4 - 2023-10-26
    No content.
  • 1.8.3 - 2023-10-18
    No content.
  • 1.8.2 - 2023-10-18
    No content.
  • 1.8.1 - 2023-10-10
    No content.
  • 1.8.0 - 2023-10-09

    In Norse mythology, Bifröst (/ˈbɪvrɒst/), is a burning rainbow bridge that reaches between Midgard (Earth) and Asgard, the realm of the gods.

    I am first to admit this is not the most exciting release from a feature standpoint. I was looking for cool code snippets but these changes are for the most part all under the hood. We are in that time period between the end of 1.x and the start of 2.0. We recently made our new reactive experiments public and continue to build those out in public with @ solidjs/signals. We need to build for the future while bridging the gap with the present.

    This version is about addressing some of the fundamentals that will help projects like SolidStart move forward while we do the transition. Async and Resources need work and are too all in. It is great to have a solution but now that we have a better understanding we need to start breaking things apart into their fundamental pieces and exposing them in ways we can better leverage. And in Solid 1.8 a big part of that is rethinking serialization, our bridge between the server and the client.

    A lot of our learning here has come from applying what we have learned when doing performance benchmarks for the work that has been funded by Google Chrome Aurora. In order to realize our goal we've had to update the foundations.

    De-duping Streaming Serialization

    This is the marquee feature of this release and is largely the work of @ lxsmnsyc. Solid has been able to serialize promises and do streaming for a couple of years now, but it was very special-cased. Now it is a generic mechanism.

    This matters because it means that we have decoupled the promise serialization from Resources, and in so decoupled the whole "when the stream is done" from them. This opens up things like nested promises and being able to serialize more complicated data structures.

    We now also have a mechanism that deeply de-dupes data serialized across flushes. If the data is ever serialized during the request we won't send it again even if sent in different streaming chunks. This is important for features like Islands where you might pass the same props to multiple Islands across different Suspense boundaries and don't want to send the data more than once. This is very beneficial where that data can be accessed at varying depths (recursive comments in say a Hackernews site) or other recursive data structures.

    Hydration Improvements

    Fragments for Hydration have been a bit of a pain and we keep seeming to have different issues reported around element duplication. Most commonly this has been around where there are lazy component siblings or where the fragment is top-level. After looking into and fixing an issue for Astro I decided to look at some of the oldest bugs in Solid and found it was a similar bug.

    In many cases, the DOM can change throughout Hydration while doing things like streaming but we need to pause and resume hydration because code isn't available yet. While we don't create elements during hydration, getting an accurate snapshot of the DOM for the current state for future list reconciliation is a process we've had a few tries at but in 1.8 we update this in a way that makes sure it doesn't get out of date.

    Also in 1.8, we have added some performance improvements to hydration in the form of not redundantly setting attributes or props as the page hydrates similar to how we don't update text. This is all migration towards a future where we don't need to do as much hydration, but it is important to note that values will be kept as they were on the server rather than how they may compute at runtime during hydration. In so we will be erroring more aggressively when mismatches happen.

    Smaller Templates

    In 1.7 we removed unnecessary closing tags from template strings. It was a bit painful because we were a bit overzealous at first. While I believe in the end we got to a good place, ultimately all but the simplest reductions have been hidden behind a compiler flag(omitNestedClosingTags). Thanks to work from @ intrnl we are implementing another template size reduction technique of removing unnecessary quotes. Quotes are actually not required by HTML in some cases and it can add up.

    Other

    Fix NGINX Server Side Includes

    Comments led with # are treated as special directives for a few different servers so we've needed to change our open hydration markers to $. As usual, your version of Solid and the Babel Plugin should be the same to ensure this matches up.

    Better Guards on Global Scripts

    Solid uses an inline HydrationScript as a way to do processing before the framework and code have loaded. To handle things like event capture and streaming. However, we didn't do a good job of guarding the right thing when multiple were added to the same page, a situation that can happen in Micro-frontends or 3rd party Islands solutions. Now the script guards against duplicate inclusion.


    With another release out, I'd like to thank everyone involved in this release and in the various efforts across our ecosystem. From everything from the Docs effort to the Playground infrastructure. We've started to tighten up on features for 1.x and moving towards our 2.0 efforts, so we ask for a bit of patience but in the coming months as we put out some RFCs for 2.0 I look forward to engaging you in discussions on the future of Solid.

    Thanks,
    @ ryansolid

  • 1.8.0-beta.2 - 2023-10-09
  • 1.8.0-beta.1 - 2023-10-04
  • 1.8.0-beta.0 - 2023-09-28
  • 1.7.12 - 2023-09-18
    No content.
from solid-js GitHub release notes

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Copy link

cloudflare-workers-and-pages bot commented Dec 28, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0fef353
Status: ✅  Deploy successful!
Preview URL: https://b637ad9b.nox-blogs.pages.dev
Branch Preview URL: https://snyk-upgrade-e0b8650e5ef155c.nox-blogs.pages.dev

View logs

Copy link

sonarcloud bot commented Dec 28, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants