Skip to content

Commit

Permalink
Fix EnergyPlusFixture.TwoSpeedDXCoilStandardRatings_Curve_Fix_Test En…
Browse files Browse the repository at this point in the history 
…ergyPlusFixture.TwoSpeedDXCoilStandardRatingsTest
  • Loading branch information
@jmarrec
jmarrec committed Aug 12, 2024
1 parent 2dee72c commit 023b7f8
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions tst/EnergyPlus/unit/DXCoils.unit.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5608,6 +5608,8 @@ TEST_F(EnergyPlusFixture, TwoSpeedDXCoilStandardRatingsTest)
state->dataGlobal->SysSizingCalc = true;
coolcoilTwoSpeed.RatedAirMassFlowRate(1) = coolcoilTwoSpeed.RatedAirVolFlowRate(1) * state->dataEnvrn->StdRhoAir;
coolcoilTwoSpeed.RatedAirMassFlowRate2 = coolcoilTwoSpeed.RatedAirVolFlowRate2 * state->dataEnvrn->StdRhoAir;
coolcoilTwoSpeed.RatedCBF(1) = 0.00000001; // autosizing is disabled so initialize coil bypass factor
coolcoilTwoSpeed.RatedCBF2 = 0.00000001;
supplyFan->maxAirMassFlowRate = supplyFan->maxAirFlowRate * state->dataEnvrn->StdRhoAir;
supplyFan->rhoAirStdInit = state->dataEnvrn->StdRhoAir;
auto &InletNode = state->dataLoopNodes->Node(supplyFan->inletNodeNum);
Expand All @@ -5629,7 +5631,7 @@ TEST_F(EnergyPlusFixture, TwoSpeedDXCoilStandardRatingsTest)
EXPECT_EQ(coolcoilTwoSpeed.InternalStaticPressureDrop, 400.0);
EXPECT_TRUE(coolcoilTwoSpeed.RateWithInternalStaticAndFanObject);
EXPECT_EQ("8.77", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilEERIP, coolcoilTwoSpeed.Name));
EXPECT_EQ("11.2", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilIEERIP, coolcoilTwoSpeed.Name));
EXPECT_EQ("10.8", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilIEERIP, coolcoilTwoSpeed.Name));
// TODO: The IEER will not be generated for this particular coil because the cpacity is below the minimum for IEER
// i.e, 65,000 Btu/h (19049.61955 Watts)
// EXPECT_EQ("N/A", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilIEERIP, coolcoilTwoSpeed.Name));
Expand All @@ -5638,7 +5640,7 @@ TEST_F(EnergyPlusFixture, TwoSpeedDXCoilStandardRatingsTest)
OutputReportPredefined::SetPredefinedTables(*state);
CalcTwoSpeedDXCoilStandardRating(*state, dXCoilIndex);
EXPECT_EQ("8.72", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilEERIP, coolcoilTwoSpeed.Name));
EXPECT_EQ("10.1", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilIEERIP, coolcoilTwoSpeed.Name));
EXPECT_EQ("9.8", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilIEERIP, coolcoilTwoSpeed.Name));
// EXPECT_EQ("N/A", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilIEERIP, coolcoilTwoSpeed.Name));
}

Expand Down Expand Up @@ -5850,6 +5852,8 @@ TEST_F(EnergyPlusFixture, TwoSpeedDXCoilStandardRatings_Curve_Fix_Test)
state->dataGlobal->SysSizingCalc = true;
coolcoilTwoSpeed.RatedAirMassFlowRate(1) = coolcoilTwoSpeed.RatedAirVolFlowRate(1) * state->dataEnvrn->StdRhoAir;
coolcoilTwoSpeed.RatedAirMassFlowRate2 = coolcoilTwoSpeed.RatedAirVolFlowRate2 * state->dataEnvrn->StdRhoAir;
coolcoilTwoSpeed.RatedCBF(1) = 0.00000001; // autosizing is disabled so initialize coil bypass factor
coolcoilTwoSpeed.RatedCBF2 = 0.00000001;
supplyFan->maxAirMassFlowRate = supplyFan->maxAirFlowRate * state->dataEnvrn->StdRhoAir;
supplyFan->rhoAirStdInit = state->dataEnvrn->StdRhoAir;
auto &InletNode = state->dataLoopNodes->Node(supplyFan->inletNodeNum);
Expand All @@ -5873,7 +5877,7 @@ TEST_F(EnergyPlusFixture, TwoSpeedDXCoilStandardRatings_Curve_Fix_Test)
EXPECT_EQ(coolcoilTwoSpeed.InternalStaticPressureDrop, 400.0);
EXPECT_TRUE(coolcoilTwoSpeed.RateWithInternalStaticAndFanObject);
EXPECT_EQ("8.77", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilEERIP, coolcoilTwoSpeed.Name));
EXPECT_EQ("11.2", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilIEERIP, coolcoilTwoSpeed.Name));
EXPECT_EQ("10.8", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilIEERIP, coolcoilTwoSpeed.Name));
// The IEER will not be generated for this particular coil because the cpacity is below the minimum for IEER
// TODO: EXPECT_EQ("N/A", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilIEERIP, coolcoilTwoSpeed.Name));

Expand All @@ -5885,7 +5889,7 @@ TEST_F(EnergyPlusFixture, TwoSpeedDXCoilStandardRatings_Curve_Fix_Test)
OutputReportPredefined::SetPredefinedTables(*state);
CalcTwoSpeedDXCoilStandardRating(*state, dXCoilIndex);
EXPECT_EQ("8.72", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilEERIP, coolcoilTwoSpeed.Name));
EXPECT_EQ("10.2", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilIEERIP, coolcoilTwoSpeed.Name));
EXPECT_EQ("9.8", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilIEERIP, coolcoilTwoSpeed.Name));
// TODO: The IEER will not be generated for this particular coil because the cpacity is below the minimum for IEER
// EXPECT_EQ("N/A", RetrievePreDefTableEntry(*state, state->dataOutRptPredefined->pdchDXCoolCoilIEERIP, coolcoilTwoSpeed.Name));

Expand Down

4 comments on commit 023b7f8

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable_fe_default_debug (jmarrec) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3695 of 3695 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable_fe_default_debug (jmarrec) - x86_64-MacOS-10.18-clang-15.0.0: OK (3654 of 3654 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable_fe_default_debug (jmarrec) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (795 of 795 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable_fe_default_debug (jmarrec) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (2056 of 2070 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1563
  • NUMERICAL: 14

Build Badge Test Badge Coverage Badge

Please sign in to comment.