Skip to content

Commit

Permalink
OA Report unit test fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
mjwitte committed Jul 7, 2020
1 parent 60ee56d commit 4dd38f2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
14 changes: 8 additions & 6 deletions src/EnergyPlus/OutputReportTabular.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6542,11 +6542,13 @@ namespace OutputReportTabular {
if (ctrlZoneNum > 0) {
for (int zoneInNode = 1; zoneInNode <= DataZoneEquipment::ZoneEquipConfig(ctrlZoneNum).NumInletNodes; ++zoneInNode) {
int airLoopNumber = DataZoneEquipment::ZoneEquipConfig(ctrlZoneNum).InletNodeAirLoopNum(zoneInNode);
if (airLoopName.empty()) {
airLoopName = DataAirSystems::PrimaryAirSystem(airLoopNumber).Name;
}
else {
airLoopName += "; " + DataAirSystems::PrimaryAirSystem(airLoopNumber).Name;
if (airLoopNumber > 0) {
if (airLoopName.empty()) {
airLoopName = DataAirSystems::PrimaryAirSystem(airLoopNumber).Name;
}
else {
airLoopName += "; " + DataAirSystems::PrimaryAirSystem(airLoopNumber).Name;
}
}
}
PreDefTableEntry(pdchOaMvAirLpNm, Zone(iZone).Name, airLoopName);
Expand Down Expand Up @@ -6593,7 +6595,7 @@ namespace OutputReportTabular {
PreDefTableEntry(pdchOaTaBzTotVentInfil, Zone(iZone).Name, ZonePreDefRep(iZone).MechVentVolTotal
+ ZonePreDefRep(iZone).SimpVentVolTotal + ZonePreDefRep(iZone).AFNInfilVolTotal + ZonePreDefRep(iZone).InfilVolTotal, 0);

if (Zone(iZone).isNominalOccupied) {
if (Zone(iZone).isNominalOccupied && (ZonePreDefRep(iZone).TotTimeOcc > 0.0)) {
// Mechanical ventilation
Real64 mechVent = ZonePreDefRep(iZone).MechVentVolTotalOcc / ZonePreDefRep(iZone).TotTimeOcc;
PreDefTableEntry(pdchOaOccBzMechVent, Zone(iZone).Name, mechVent);
Expand Down
1 change: 1 addition & 0 deletions tst/EnergyPlus/unit/UnitaryHybridAirConditioner.unit.cc
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,7 @@ TEST_F(EnergyPlusFixture, Test_UnitaryHybridAirConditioner_Unittest)
ZoneOAVolStdRho.allocate(NumOfZones);
ZoneOAVolCrntRho.allocate(NumOfZones);
ZoneMechACH.allocate(NumOfZones);
DataHeatBalance::ZnAirRpt.allocate(NumOfZones);
MAT.allocate(NumOfZones);
ZoneAirHumRatAvg.allocate(NumOfZones);
MaxHeatingLoadMetByVent.allocate(NumOfZones);
Expand Down

8 comments on commit 4dd38f2

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (2873 of 2927 tests passed, 659 test warnings)

Messages:\n

  • 713 tests had: AUD diffs.
  • 613 tests had: RDD diffs.
  • 54 tests had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 675
  • Failed: 54

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (mjwitte) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (mjwitte) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (13 of 13 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1467 of 1467 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (714 of 714 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (mjwitte) - Win64-Windows-10-VisualStudio-16: OK (2154 of 2154 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (mjwitte) - x86_64-MacOS-10.13-clang: OK (2833 of 2887 tests passed, 655 test warnings)

Messages:\n

  • 709 tests had: AUD diffs.
  • 610 tests had: RDD diffs.
  • 54 tests had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 655
  • Failed: 54

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (mjwitte) - x86_64-MacOS-10.15-clang-11.0.0: OK (2833 of 2887 tests passed, 655 test warnings)

Messages:\n

  • 709 tests had: AUD diffs.
  • 610 tests had: RDD diffs.
  • 54 tests had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 655
  • Failed: 54

Build Badge Test Badge

Please sign in to comment.