Skip to content

Commit

Permalink
Back to forcing no_auto_ptr on macos
Browse files Browse the repository at this point in the history
  • Loading branch information
lefticus committed Oct 24, 2020
1 parent 1dbf364 commit 654c1a0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
7 changes: 7 additions & 0 deletions cmake/CompilerFlags.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ ADD_DEFINITIONS("-DXML_STATIC")

SET(CMAKE_CXX_STANDARD 17)

if ( APPLE )
# Force no auto ptr
# TODO remove this after kiva/boost is updated to a version that supports
# C++17
ADD_DEFINITIONS("-DBOOST_NO_AUTO_PTR")
endif()

IF ( MSVC AND NOT ( "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Intel" ) ) # Visual C++ (VS 2013)

# COMPILER FLAGS
Expand Down
2 changes: 0 additions & 2 deletions third_party/kiva-ep/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ set( CMAKE_LIBRARY_OUTPUT_DIRECTORY "${kiva_BINARY_DIR}" )
set( CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${kiva_BINARY_DIR}" )
set( CMAKE_RUNTIME_OUTPUT_DIRECTORY "${kiva_BINARY_DIR}" )

SET(CMAKE_CXX_STANDARD 17)

if (KIVA_EXE_BUILD)
set(CompilerFlags
CMAKE_CXX_FLAGS
Expand Down

5 comments on commit 654c1a0

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move_to_c++17_keep_old_boost (lefticus) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (3026 of 3026 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move_to_c++17_keep_old_boost (lefticus) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1550 of 1550 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move_to_c++17_keep_old_boost (lefticus) - x86_64-MacOS-10.15-clang-11.0.0: OK (2986 of 2986 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move_to_c++17_keep_old_boost (lefticus) - Win64-Windows-10-VisualStudio-16: OK (2242 of 2242 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move_to_c++17_keep_old_boost (lefticus) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (722 of 722 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.