-
Notifications
You must be signed in to change notification settings - Fork 390
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move cycling ratio to inside compressor spd calc for heating
after multiplying cycling ratio to the outdoor unit, some super large COP appeared in some timesteps. This is probably due to the cycling ratio calculation, moving it to inside the compressor speed calculation fixed this problem.
- Loading branch information
Yujie Xu
committed
Feb 26, 2024
1 parent
b9c6bff
commit 7d79eac
Showing
3 changed files
with
65 additions
and
76 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d79eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vrfCoolingFan (Unknown) - Win64-Windows-10-VisualStudio-16: OK (2757 of 2758 tests passed, 0 test warnings)
Failures:\n
EnergyPlusFixture Test Summary
7d79eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vrfCoolingFan (Unknown) - x86_64-MacOS-10.18-clang-15.0.0: OK (3269 of 3545 tests passed, 256 test warnings)
Messages:\n
Failures:\n
EnergyPlusFixture Test Summary
regression Test Summary
7d79eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vrfCoolingFan (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3310 of 3586 tests passed, 259 test warnings)
Messages:\n
Failures:\n
EnergyPlusFixture Test Summary
regression Test Summary
7d79eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vrfCoolingFan (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1970 of 1971 tests passed, 0 test warnings)
Failures:\n
EnergyPlusFixture Test Summary
7d79eac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vrfCoolingFan (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (790 of 790 tests passed, 0 test warnings)