Skip to content

Commit

Permalink
OA Report - merge cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
mjwitte committed Dec 9, 2020
1 parent bb3b8df commit b513ed2
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
3 changes: 2 additions & 1 deletion src/EnergyPlus/AirflowNetworkBalanceManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8517,7 +8517,8 @@ namespace AirflowNetworkBalanceManager {
state.dataAirflowNetworkBalanceManager->AirflowNetworkZnRpt(i).MixVolume = (state.dataAirflowNetworkBalanceManager->exchangeData(i).SumMMCp / CpAir / AirDensity) * ReportingConstant;
state.dataAirflowNetworkBalanceManager->AirflowNetworkZnRpt(i).MixMass = (state.dataAirflowNetworkBalanceManager->exchangeData(i).SumMMCp / CpAir) * ReportingConstant;
// save values for predefined report
Real64 StdDensInfilVolume = (dataAirflowNetworkBalanceManager.exchangeData(i).SumMCp / CpAir / StdRhoAir) * ReportingConstant; // compute volume using standard density air
Real64 StdDensInfilVolume = (state.dataAirflowNetworkBalanceManager->exchangeData(i).SumMCp / CpAir / state.dataEnvrn->StdRhoAir) *
ReportingConstant; // compute volume using standard density air
ZonePreDefRep(i).AFNInfilVolTotal += StdDensInfilVolume * Zone(i).Multiplier * Zone(i).ListMultiplier;
if (StdDensInfilVolume < ZonePreDefRep(i).AFNInfilVolMin) {
ZonePreDefRep(i).AFNInfilVolMin = StdDensInfilVolume * Zone(i).Multiplier * Zone(i).ListMultiplier;
Expand Down
4 changes: 2 additions & 2 deletions src/EnergyPlus/DataSizing.cc
Original file line number Diff line number Diff line change
Expand Up @@ -945,15 +945,15 @@ namespace DataSizing {
}
}

Real64 ZoneAirDistributionData::calculateEz(int const ZoneNum) // Zone index
Real64 ZoneAirDistributionData::calculateEz(EnergyPlusData &state, int const ZoneNum) // Zone index
{
Real64 zoneEz = 1.0;
// Calc the zone supplied OA flow rate counting the zone air distribution effectiveness
// First check whether the zone air distribution effectiveness schedule exists, if yes uses it;
// otherwise uses the inputs of zone distribution effectiveness in cooling mode or heating mode
if (this->ZoneADEffSchPtr > 0) {
// Get schedule value for the zone air distribution effectiveness
zoneEz = ScheduleManager::GetCurrentScheduleValue(this->ZoneADEffSchPtr);
zoneEz = ScheduleManager::GetCurrentScheduleValue(state, this->ZoneADEffSchPtr);
} else {
Real64 zoneLoad = DataZoneEnergyDemands::ZoneSysEnergyDemand(ZoneNum).TotalOutputRequired;

Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/DataSizing.hh
Original file line number Diff line number Diff line change
Expand Up @@ -1161,7 +1161,7 @@ namespace DataSizing {
{
}

Real64 calculateEz(int const ZoneNum); // Zone index
Real64 calculateEz(EnergyPlusData &state, int const ZoneNum); // Zone index
};

// Object Data
Expand Down
5 changes: 2 additions & 3 deletions src/EnergyPlus/OutputReportTabular.cc
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@
#include <EnergyPlus/Data/EnergyPlusData.hh>
#include <EnergyPlus/DataAirLoop.hh>
#include <EnergyPlus/DataAirSystems.hh>
#include <EnergyPlus/DataCostEstimate.hh>
#include <EnergyPlus/DataDaylighting.hh>
#include <EnergyPlus/DataDefineEquip.hh>
#include <EnergyPlus/DataEnvironment.hh>
Expand Down Expand Up @@ -6523,10 +6522,10 @@ namespace OutputReportTabular {
int airLoopNumber = DataZoneEquipment::ZoneEquipConfig(ctrlZoneNum).InletNodeAirLoopNum(zoneInNode);
if (airLoopNumber > 0) {
if (airLoopName.empty()) {
airLoopName = DataAirSystems::PrimaryAirSystem(airLoopNumber).Name;
airLoopName = state.dataAirSystemsData->PrimaryAirSystems(airLoopNumber).Name;
}
else {
airLoopName += "; " + DataAirSystems::PrimaryAirSystem(airLoopNumber).Name;
airLoopName += "; " + state.dataAirSystemsData->PrimaryAirSystems(airLoopNumber).Name;
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions src/EnergyPlus/SystemReports.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1950,7 +1950,7 @@ namespace SystemReports {
ZoneOAVolFlowCrntRho.allocate(state.dataGlobal->NumOfZones);
ZoneOAVolCrntRho.allocate(state.dataGlobal->NumOfZones);
ZoneMechACH.allocate(state.dataGlobal->NumOfZones);
ZoneTargetVentilationFlowVoz.allocate(NumOfZones);
ZoneTargetVentilationFlowVoz.allocate(state.dataGlobal->NumOfZones);

SysTotZoneLoadHTNG.allocate(NumPrimaryAirSys);
SysTotZoneLoadCLNG.allocate(NumPrimaryAirSys);
Expand Down Expand Up @@ -2418,7 +2418,7 @@ namespace SystemReports {
"Average",
ZoneEquipConfig(ZoneIndex).ZoneName);

SetupOutputVariable("Zone Target Voz Ventilation Flow Rate",
SetupOutputVariable(state, "Zone Target Voz Ventilation Flow Rate",
OutputProcessor::Unit::m3_s,
ZoneTargetVentilationFlowVoz(ZoneIndex),
"HVAC",
Expand Down Expand Up @@ -4527,11 +4527,11 @@ namespace SystemReports {
bool UseOccSchFlag = true;
bool UseMinOASchFlag = true;
ZoneTargetVentilationFlowVoz = DataZoneEquipment::CalcDesignSpecificationOutdoorAir(
ZoneEquipConfig(CtrlZoneNum).ZoneDesignSpecOAIndex, ActualZoneNum, UseOccSchFlag, UseMinOASchFlag);
state, ZoneEquipConfig(CtrlZoneNum).ZoneDesignSpecOAIndex, ActualZoneNum, UseOccSchFlag, UseMinOASchFlag);
if (ZoneEquipConfig(CtrlZoneNum).ZoneAirDistributionIndex > 0) {
ZoneTargetVentilationFlowVoz =
ZoneTargetVentilationFlowVoz /
DataSizing::ZoneAirDistribution(ZoneEquipConfig(CtrlZoneNum).ZoneAirDistributionIndex).calculateEz(ActualZoneNum);
DataSizing::ZoneAirDistribution(ZoneEquipConfig(CtrlZoneNum).ZoneAirDistributionIndex).calculateEz(state, ActualZoneNum);
}


Expand Down
2 changes: 1 addition & 1 deletion src/EnergyPlus/ZoneEquipmentManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1279,7 +1279,7 @@ namespace ZoneEquipmentManager {
} else {
FinalZoneSizing(CtrlZoneNum).ZonePeakOccupancy = TotPeopleInZone;
}
ZoneMinOccupancy += TotPeopleInZone * ScheduleManager::GetScheduleMinValue(People(PeopleNum).NumberOfPeoplePtr);
ZoneMinOccupancy += TotPeopleInZone * ScheduleManager::GetScheduleMinValue(state, People(PeopleNum).NumberOfPeoplePtr);
}
}
FinalZoneSizing(CtrlZoneNum).TotalZoneFloorArea =
Expand Down

5 comments on commit b513ed2

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (mjwitte) - x86_64-MacOS-10.15-clang-11.0.0: OK (2938 of 2992 tests passed, 661 test warnings)

Messages:\n

  • 715 tests had: AUD diffs.
  • 615 tests had: RDD diffs.
  • 54 tests had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 662
  • Failed: 54

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (2977 of 3032 tests passed, 664 test warnings)

Messages:\n

  • 719 tests had: AUD diffs.
  • 618 tests had: RDD diffs.
  • 55 tests had: Table big diffs.
  • 1 test had: EIO diffs.
  • 1 test had: ESO small diffs.
  • 1 test had: MTR small diffs.

Failures:\n

regression Test Summary

  • Passed: 681
  • Failed: 55

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1558 of 1558 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (mjwitte) - Win64-Windows-10-VisualStudio-16: OK (2249 of 2249 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: Coverage Too Low

Build Badge Test Badge Coverage Badge

Please sign in to comment.