Skip to content

Commit

Permalink
Fix failing tests with new formatting changes
Browse files Browse the repository at this point in the history
 - Note that the original code was incorrect, 20 formatted parameters
   but only 19 passed in.
 - New code does not have a trailing `,` now

Re: @Myoldmopar
  • Loading branch information
lefticus committed Jan 7, 2020
1 parent b3aed94 commit c483c41
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/EnergyPlus/DXCoils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13533,7 +13533,7 @@ namespace DXCoils {
"! <VAV DX Cooling Coil Standard Rating Information>, DX Coil Type, DX Coil Name, Fan Type, Fan Name, Standard Net Cooling Capacity {W}, Standard Net Cooling Capacity {Btu/h}, IEER {Btu/W-h}, COP 100% Capacity {W/W}, COP 75% Capacity {W/W}, COP 50% Capacity {W/W}, COP 25% Capacity {W/W}, EER 100% Capacity {Btu/W-h}, EER 75% Capacity {Btu/W-h}, EER 50% Capacity {Btu/W-h}, EER 25% Capacity {Btu/W-h}, Supply Air Flow 100% {kg/s}, Supply Air Flow 75% {kg/s},Supply Air Flow 50% {kg/s},Supply Air Flow 25% {kg/s}\n");

static constexpr auto Format_891{
" VAV DX Cooling Coil Standard Rating Information, {},{},{},{},{},{:.2f},{:.2f},{:.2f},{:.2f},{:.2f},{:.2f},{:.2f},{:.2f},{:.2f},{:.2f},{:.2f},{:.4f},{:.4f},{:.4f},{:.4f}\n"};
" VAV DX Cooling Coil Standard Rating Information, {},{},{},{},{:.2f},{:.2f},{:.2f},{:.2f},{:.2f},{:.2f},{:.2f},{:.2f},{:.2f},{:.2f},{:.2f},{:.4f},{:.4f},{:.4f},{:.4f}\n"};

// Get fan index and name if not already available
if (DXCoil(DXCoilNum).SupplyFanIndex == -1)
Expand Down

7 comments on commit c483c41

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove_objexx_gio (lefticus) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove_objexx_gio (lefticus) - x86_64-Linux-Ubuntu-18.04-custom_check: Build Failed

Build Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove_objexx_gio (lefticus) - x86_64-MacOS-10.13-clang: OK (2596 of 2596 tests passed, 670 test warnings)

Messages:\n

  • 670 tests had: EIO diffs.
  • 1 test had: Table small diffs.

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove_objexx_gio (lefticus) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2636 of 2636 tests passed, 674 test warnings)

Messages:\n

  • 674 tests had: EIO diffs.
  • 1 test had: Table small diffs.

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove_objexx_gio (lefticus) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1254 of 1254 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove_objexx_gio (lefticus) - Win64-Windows-10-VisualStudio-16: OK (2369 of 2596 tests passed, 444 test warnings)

Messages:\n

  • 444 tests had: EIO diffs.
  • 18 tests had: AUD diffs.
  • 22 tests had: BND diffs.
  • 17 tests had: DXF diffs.
  • 34 tests had: ERR diffs.
  • 5 tests had: SLN diffs.
  • 19 tests had: MDD diffs.
  • 26 tests had: MTD diffs.
  • 19 tests had: RDD diffs.
  • 6 tests had: SHD diffs.
  • 1 test had: MAP diffs.

Failures:\n

integration Test Summary

  • Passed: 445
  • Failed: 227

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove_objexx_gio (lefticus) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (674 of 675 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 674
  • Timeout: 1

Build Badge Test Badge Coverage Badge

Please sign in to comment.