Skip to content

Commit

Permalink
Merge pull request #8626 from NREL/hotfixHeatBalFiniteDiffForWindows
Browse files Browse the repository at this point in the history 
Fix build error on windows - remove constexpressed externs
  • Loading branch information
@Myoldmopar
Myoldmopar committed Mar 17, 2021
2 parents 23ee3fd + ecfaa2b commit d45ca77
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/EnergyPlus/HeatBalFiniteDiffManager.hh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,6 @@ struct EnergyPlusData;
namespace HeatBalFiniteDiffManager {

// MODULE PARAMETER DEFINITIONS:
extern Real64 const Lambda;
extern Real64 const smalldiff; // Used in places where "equality" tests should not be used.

extern int const CrankNicholsonSecondOrder; // original CondFD scheme. semi implicit, second order in time
extern int const FullyImplicitFirstOrder; // fully implicit scheme, first order in time.
extern Array1D_string const cCondFDSchemeType;

extern Real64 const TempInitValue; // Initialization value for Temperature
Expand Down

5 comments on commit d45ca77

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (Myoldmopar) - x86_64-MacOS-10.15-clang-11.0.0: OK (2342 of 2342 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (2362 of 2362 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1618 of 1618 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (Myoldmopar) - Win64-Windows-10-VisualStudio-16: OK (2313 of 2313 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (Myoldmopar) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (726 of 727 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 726
  • Timeout: 1

Build Badge Test Badge Coverage Badge

Please sign in to comment.