Skip to content

Commit

Permalink
change OnOffFanPartLoadFraction back to use PLF
Browse files Browse the repository at this point in the history
  • Loading branch information
Yujie Xu committed Aug 12, 2024
1 parent 261699a commit de9baf3
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/EnergyPlus/DXCoils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16880,7 +16880,7 @@ void CalcVRFCoolingCoil_FluidTCtrl(EnergyPlusData &state,
}

// If cycling fan, send coil part-load fraction to on/off fan via HVACDataGlobals
if (fanOp == HVAC::FanOp::Cycling) state.dataHVACGlobal->OnOffFanPartLoadFraction = thisDXCoil.CoolingCoilRuntimeFraction;
if (fanOp == HVAC::FanOp::Cycling) state.dataHVACGlobal->OnOffFanPartLoadFraction = PLF;

// Check for saturation error and modify temperature at constant enthalpy
if (OutletAirTemp < PsyTsatFnHPb(state, OutletAirEnthalpy, OutdoorPressure)) {
Expand Down
11 changes: 10 additions & 1 deletion src/EnergyPlus/HVACVariableRefrigerantFlow.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12828,7 +12828,16 @@ void VRFTerminalUnitEquipment::CalcVRF_FluidTCtrl(EnergyPlusData &state,
auto *fan = state.dataFans->fans(state.dataHVACVarRefFlow->VRFTU(VRFTUNum).FanIndex);
if (state.dataHVACVarRefFlow->VRFTU(VRFTUNum).fanType == HVAC::FanType::SystemModel) {
if (OnOffAirFlowRatio > 0.0) {
fan->simulate(state, FirstHVACIteration, _, _, _, fan->inletAirMassFlowRate, OnOffFanPartLoadFraction, 0, 0, _);
fan->simulate(state,
FirstHVACIteration,
_,
_,
_,
fan->inletAirMassFlowRate,
state.dataDXCoils->DXCoil(this->CoolCoilIndex).CoolingCoilRuntimeFraction,
0,
0,
_);
} else {
fan->simulate(state, FirstHVACIteration, _, _, PartLoadRatio);
}
Expand Down

4 comments on commit de9baf3

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfCoolingFan (Unknown) - x86_64-MacOS-10.18-clang-15.0.0: OK (3527 of 3654 tests passed, 468 test warnings)

Messages:\n

  • 592 tests had: AUD diffs.
  • 562 tests had: EIO diffs.
  • 283 tests had: RDD diffs.
  • 123 tests had: Table small diffs.
  • 124 tests had: Table big diffs.
  • 2 tests had: ESO small diffs.
  • 1 test had: MTR small diffs.
  • 2 tests had: MTD diffs.
  • 4 tests had: BND diffs.
  • 5 tests had: ERR diffs.
  • 4 tests had: ESO big diffs.
  • 1 test had: MDD diffs.
  • 4 tests had: Table string diffs.
  • 1 test had: IDF diffs.
  • 2 tests had: MTR big diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1574
  • Failed: 3

regression Test Summary

  • Passed: 667
  • Failed: 124

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfCoolingFan (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3568 of 3695 tests passed, 469 test warnings)

Messages:\n

  • 593 tests had: AUD diffs.
  • 563 tests had: EIO diffs.
  • 283 tests had: RDD diffs.
  • 123 tests had: Table small diffs.
  • 124 tests had: Table big diffs.
  • 2 tests had: ESO small diffs.
  • 1 test had: MTR small diffs.
  • 2 tests had: MTD diffs.
  • 4 tests had: BND diffs.
  • 5 tests had: ERR diffs.
  • 4 tests had: ESO big diffs.
  • 1 test had: MDD diffs.
  • 4 tests had: Table string diffs.
  • 1 test had: IDF diffs.
  • 2 tests had: MTR big diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1574
  • Failed: 3

regression Test Summary

  • Passed: 687
  • Failed: 124

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfCoolingFan (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (2067 of 2070 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1574
  • Failed: 3

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfCoolingFan (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (795 of 795 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.