Allow ZoneHVAC:WindowAirConditioner with Airflow Network simulations
#10617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lymereJ
added
NewFeature
lymereJ
commented
Jul 22, 2024
Comment on lines
+10279
to
+10284
|
|
||
| // Skip Window AC with no OA | ||
| if (GetWindowACNodeNumber(m_state, i)) { | ||
| NodeFound(i) = true; | ||
| WindowACFound = true; | ||
| } |
There was a problem hiding this comment.
Use the same approach as before by calling a function that checks if a node is part of a ZoneHVAC:WindowAirConditioner and if so allows it to exist without being part of the AFN.
Comment on lines
+1513
to
+1517
| if (windowAC.OutAirVolFlow == 0) { | ||
| windowACOutdoorAir = true; | ||
| } else { | ||
| windowACOutdoorAir = false; | ||
| } |
There was a problem hiding this comment.
Only allow ZoneHVAC:WindowAirConditioners that do not provide outdoor air to not interfere with the AFN.
jasondegraw
approved these changes
Jul 24, 2024
Myoldmopar
approved these changes
Jul 25, 2024
| } | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
I could nitpick here,
windowACOutdoorAir = windowAC.OutAirVolFlow == 0;- Why are you declaring the node indexes equal to zero and immediately reassigning them?
- The logic in the node number IF check is pretty difficult to read, could it be written in a more meaningful/readable way?
None of these are actual requests unless there is other work that needs done.
|
All happy with develop pulled in, let's get this merged. Thanks @lymereJ and @jasondegraw |
lymereJ
added a commit
that referenced
this pull request
Aug 2, 2024
…and docs, and address comments from #10617.
Merged
15 tasks
Myoldmopar
added a commit
that referenced
this pull request
Aug 16, 2024
Follow up to #10617 and allow other `ZoneHVAC:*` component with Airflow Network simulations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
This pull request allows simulations using the Airflow Network feature to proceed if a
ZoneHVAC:WindowAirConditioneris included in a model only and only if its outdoor air flow rate is 0.Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.