Reduce use of Array1S objects #7813
Conversation
jasondegraw
added
the
Refactoring
|
No problems that I see. This looks ready. |
There was a problem hiding this comment.
I was expecting to see at least some unit test code change to accommodate this, but I get that it shouldn't really be necessary, so this is fine. You are touching a lot of code that is unit tested already, so I'd expect to see lots of failures if you broke something. I have questions about the code you changed, but not the changes you made, just some 🤦♂️ when looking at the original code.
This is good to go by me. Develop has now moved a little, so I can pull this branch and merge in develop and run some quick tests locally.
| ) | ||
| { | ||
|
|
||
| // SUBROUTINE INFORMATION: | ||
| // AUTHOR Linda Lawrie | ||
| // DATE WRITTEN May 2005 | ||
| // MODIFIED na | ||
| // MODIFIED Jason DeGraw 2/12/2020, de-optionalized |
| @@ -599,7 +599,7 @@ namespace DataEnvironment { | |||
| ShowFatalError("Program terminates due to preceding condition(s)."); | |||
| } | |||
|
|
|||
| void SetWindSpeedAt(int const NumItems, Array1S<Real64> const Heights, Array1S<Real64> LocalWindSpeed, std::string const &EP_UNUSED(Settings)) | |||
| void SetWindSpeedAt(int const NumItems, const Array1D<Real64> &Heights, Array1D<Real64> &LocalWindSpeed, std::string const &EP_UNUSED(Settings)) | |||
There was a problem hiding this comment.
Why is this an array anyway? Not your problem, just rambling...
| @@ -3047,7 +3047,6 @@ namespace SimulationManager { | |||
| EndUses, | |||
| Groups, | |||
| VarNames, | |||
| _, | |||
|
Tested locally, looking good. Merging. |
Pull request overview
Reduces the use of the
Array1Sobject, generally replacing theArray1Swith a reference to anArray1Dobject. This PR mainly removes non-slicing uses of the object, leaving in place 2D to 1D slicing and other similar uses. The changes here should result in no diffs. This is part of the larger effort to migrate tostd::vector.Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.