Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of On-Off Control Capabilities for the Variable Flow and Electric Low Temperature Radiant Systems #8113

Merged
merged 6 commits into from
Jul 1, 2020
Merged

Implementation of On-Off Control Capabilities for the Variable Flow and Electric Low Temperature Radiant Systems #8113

merged 6 commits into from
Jul 1, 2020

Commits on Jun 26, 2020

  1. Addition of On/Off Control 

    This commit implements the possibility of on/off control for variable flow and electric radiant system.  It includes code changes as well as changes to two IDF files to show that on/off control is working.
    @RKStrand
    RKStrand committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    b233cce View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into 8044-LowTempRadSysOnOffControl

    @RKStrand
    RKStrand committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    a23f07f View commit details
    Browse the repository at this point in the history

  3. On-Off Control Sub Unit Test 

    Addition of the unit test to verify that the new on-off control subroutine is working properly.
    @RKStrand
    RKStrand committed Jun 26, 2020
    6 Configuration menu
    Copy the full SHA
    a6129ad View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. Merge branch 'develop' into 8044-LowTempRadSysOnOffControl

    @RKStrand
    RKStrand committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    1780fc5 View commit details
    Browse the repository at this point in the history

  2. Removal of checks on throttling range 

    This commit includes changes to the code to eliminate checks on the throttling range that are already made in the IDD.
    @RKStrand
    RKStrand committed Jun 30, 2020
    6 Configuration menu
    Copy the full SHA
    1175dd7 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. Rebug the code 

    This commit unfixes a "bug" that was discovered during the implementation of on-off control for radiant systems.  The bug is that the variable flow radiant system the old code allowed for the maximum flow fraction to be greater than 1.0.  Unfixing this to see if the surprising number of output file diffs were caused by this fix.
    @RKStrand
    RKStrand committed Jul 1, 2020
    6 Configuration menu
    Copy the full SHA
    e14abb6 View commit details
    Browse the repository at this point in the history