Coil:Cooling:DX updates

doc/ems-application-guide/src/ems-actuators/hvac-systems-001.tex

@@ -94,7 +94,7 @@ \subsection{Fan}\label{fan}
 
 \subsection{DX Cooling Coils}\label{dx-cooling-coils}
 
-Actuators are available for overriding the autosize values related to the size of single speed DX coils.~ Actuators called ``Coil:Cooling:DX:SingleSpeed'' are available with control types ``Autosized Rated Air Flow Rate'' (in m3/s), ``Autosized Rated Sensible Heat Ratio'' (in W/W), and ``Autosized Rated Total Cooling Capacity'' (in W).~ These are only useful from the calling point named AfterComponentInputReadIn.
+Actuators are available for overriding the autosize rated airflow rate and total cooling capacity of the Coil:Cooling:DX object.~ Actuators called ``Coil:Cooling:DX:CurveFit:SingleSpeed'' are available with control types ``Autosized Rated Air Flow Rate'' (in m3/s) and ``Autosized Rated Total Cooling Capacity'' (in W).~ These are only useful from the calling point named AfterComponentInputReadIn.
 
 \subsection{Unitary Equipment}\label{unitary-equipment}
 

src/EnergyPlus/Coils/CoilCoolingDX.hh

@@ -78,9 +78,10 @@ struct CoilCoolingDX
     static int factory(EnergyPlusData &state, std::string const &coilName);
     static void getInput(EnergyPlusData &state);
     static void clear_state();
+    static void reportAllStandardRatings(EnergyPlusData& state);
     void instantiateFromInputSpec(EnergyPlusData &state, const CoilCoolingDXInputSpecification &input_data);
     void oneTimeInit();
-    void simulate(EnergyPlusData &state, int useAlternateMode, Real64 PLR, int speedNum, Real64 speedRatio, int fanOpMode, Real64 LoadSHR = -1.0);
+    void simulate(EnergyPlusData &state, int useAlternateMode, Real64 PLR, int speedNum, Real64 speedRatio, int const fanOpMode, bool const singleMode, Real64 LoadSHR = -1.0);
     void setData(int fanIndex, int fanType, std::string const &fanName, int airLoopNum);
     void getFixedData(int &evapInletNodeIndex,
                       int &evapOutletNodeIndex,
@@ -95,13 +96,16 @@ struct CoilCoolingDX
     static void inline passThroughNodeData(DataLoopNode::NodeData &in, DataLoopNode::NodeData &out);
     void size(EnergyPlusData &state);
 
+    int getNumModes();
+    int getOpModeCapFTIndex(bool useAlternateMode = false);
+    Real64 condMassFlowRate(bool useAlternateMode);
+
     CoilCoolingDXInputSpecification original_input_specs;
     std::string name;
     bool myOneTimeInitFlag = true;
     int evapInletNodeIndex = 0;
     int evapOutletNodeIndex = 0;
     int availScheduleIndex = 0;
-    // int condZoneIndex = 0;
     int condInletNodeIndex = 0;
     int condOutletNodeIndex = 0;
     CoilCoolingDXCurveFitPerformance performance;
@@ -112,16 +116,18 @@ struct CoilCoolingDX
     int evaporativeCondSupplyTankIndex = 0;
     int evaporativeCondSupplyTankARRID = 0;
     Real64 evaporativeCondSupplyTankVolumeFlow = 0.0;
-    // Real64 evaporativeCondSupplyTankVolumeConsumption = 0.0;
+    Real64 evaporativeCondSupplyTankConsump = 0.0;
     Real64 evapCondPumpElecPower = 0.0;
     Real64 evapCondPumpElecConsumption = 0.0;
     int airLoopNum = 0; // Add for AFN compatibility, revisit at a later date
     int supplyFanIndex = 0;
     int supplyFanType = 0;
     std::string supplyFanName = "";
-    bool doStandardRatingFlag = true;
     bool SubcoolReheatFlag = false; // Subcool reheat coil control
 
+    CoilCoolingDXCurveFitSpeed &normModeNomSpeed();
+    CoilCoolingDXCurveFitSpeed &altModeNomSpeed();
+
     // report variables
     Real64 totalCoolingEnergyRate = 0.0;
     Real64 totalCoolingEnergy = 0.0;
@@ -147,9 +153,19 @@ struct CoilCoolingDX
     Real64 wasteHeatEnergy = 0.0;
     Real64 recoveredHeatEnergy = 0.0;
     Real64 recoveredHeatEnergyRate = 0.0;
+    Real64 condenserInletTemperature = 0.0;
+    int dehumidificationMode = 0;
+    bool reportCoilFinalSizes = true;
+    bool isSecondaryDXCoilInZone = false;
+    Real64 secCoilSensHeatRejEnergyRate = 0.0;
+    Real64 secCoilSensHeatRejEnergy = 0.0;
+
+    void setToHundredPercentDOAS();
+    bool isHundredPercentDOAS = false;
 };
 
 extern std::vector<CoilCoolingDX> coilCoolingDXs;
+extern bool stillNeedToReportStandardRatings; // standard ratings flag for all coils to report at the same time
 extern bool coilCoolingDXGetInputFlag;
 extern std::string const coilCoolingDXObjectName;
 

src/EnergyPlus/Coils/CoilCoolingDXCurveFitOperatingMode.cc

@@ -53,6 +53,7 @@
 #include <EnergyPlus/DataIPShortCuts.hh>
 #include <EnergyPlus/DataSizing.hh>
 #include <EnergyPlus/Data/EnergyPlusData.hh>
+#include <EnergyPlus/EMSManager.hh>
 #include <EnergyPlus/InputProcessing/InputProcessor.hh>
 #include <EnergyPlus/Psychrometrics.hh>
 #include <EnergyPlus/ReportSizingManager.hh>
@@ -67,12 +68,19 @@ void CoilCoolingDXCurveFitOperatingMode::instantiateFromInputSpec(EnergyPlusData
     this->original_input_specs = input_data;
     this->name = input_data.name;
     this->ratedGrossTotalCap = input_data.gross_rated_total_cooling_capacity;
+    if (this->ratedGrossTotalCap == DataSizing::AutoSize) this->ratedGrossTotalCapIsAutosized = true;
     this->ratedEvapAirFlowRate = input_data.rated_evaporator_air_flow_rate;
+    if (this->ratedEvapAirFlowRate == DataSizing::AutoSize) this->ratedEvapAirFlowRateIsAutosized = true;
     this->ratedCondAirFlowRate = input_data.rated_condenser_air_flow_rate;
-    this->maxCyclingRate = input_data.maximum_cycling_rate;
+    this->timeForCondensateRemoval = input_data.nominal_time_for_condensate_removal_to_begin;
     this->evapRateRatio = input_data.ratio_of_initial_moisture_evaporation_rate_and_steady_state_latent_capacity;
+    this->maxCyclingRate = input_data.maximum_cycling_rate;
     this->latentTimeConst = input_data.latent_capacity_time_constant;
-    this->timeForCondensateRemoval = input_data.nominal_time_for_condensate_removal_to_begin;
+    if (UtilityRoutines::SameString(input_data.apply_latent_degradation_to_speeds_greater_than_1, "Yes")) {
+        this->applyLatentDegradationAllSpeeds = true;
+    } else {
+        this->applyLatentDegradationAllSpeeds = false;
+    }
     // TODO: UNUSED apply_latent_degradation_to_speeds_greater_than_1
     this->nominalEvaporativePumpPower = input_data.nominal_evap_condenser_pump_power;
 
@@ -82,6 +90,9 @@ void CoilCoolingDXCurveFitOperatingMode::instantiateFromInputSpec(EnergyPlusData
         ShowWarningError(routineName + this->object_name + "=\"" + this->name + "\":");
         ShowContinueError("...At least one of the four input parameters for the latent capacity degradation model");
         ShowContinueError("...is set to zero. Therefore, the latent degradation model will not be used for this simulation.");
+        this->latentDegradationActive = false;
+    } else if (this->maxCyclingRate > 0.0 && this->evapRateRatio > 0.0 && this->latentTimeConst > 0.0 && this->timeForCondensateRemoval > 0.0) {
+        this->latentDegradationActive = true;
     }
 
     if (UtilityRoutines::SameString(input_data.condenser_type, "AirCooled")) {
@@ -98,6 +109,9 @@ void CoilCoolingDXCurveFitOperatingMode::instantiateFromInputSpec(EnergyPlusData
         this->speeds.emplace_back(state, speed_name);
     }
 
+    // convert speed num in IDF to vector index
+    this->nominalSpeedIndex = input_data.nominal_speed_number - 1;
+
     if (errorsFound) {
         ShowFatalError(routineName + "Errors found in getting " + this->object_name + " input. Preceding condition(s) causes termination.");
     }
@@ -151,6 +165,23 @@ CoilCoolingDXCurveFitOperatingMode::CoilCoolingDXCurveFitOperatingMode(EnergyPlu
     }
 }
 
+void CoilCoolingDXCurveFitOperatingMode::oneTimeInit() {
+    if (DataGlobals::AnyEnergyManagementSystemInModel) {
+        SetupEMSActuator(this->object_name,
+                         this->name,
+                         "Autosized Rated Air Flow Rate",
+                         "[m3/s]",
+                         this->ratedAirVolFlowEMSOverrideON,
+                         this->ratedAirVolFlowEMSOverrideValue);
+        SetupEMSActuator(this->object_name,
+                         this->name,
+                         "Autosized Rated Total Cooling Capacity",
+                         "[W]",
+                         this->ratedTotCapFlowEMSOverrideON,
+                         this->ratedTotCapFlowEMSOverrideValue);
+    }
+}
+
 void CoilCoolingDXCurveFitOperatingMode::size(EnergyPlusData &state)
 {
 
@@ -160,20 +191,28 @@ void CoilCoolingDXCurveFitOperatingMode::size(EnergyPlusData &state)
     bool PrintFlag = true;
 
     int SizingMethod = DataHVACGlobals::CoolingAirflowSizing;
+    DataSizing::DataEMSOverrideON = this->ratedAirVolFlowEMSOverrideON;
+    DataSizing::DataEMSOverride = this->ratedAirVolFlowEMSOverrideValue;
     std::string SizingString = "Rated Evaporator Air Flow Rate [m3/s]";
     Real64 TempSize = this->original_input_specs.rated_evaporator_air_flow_rate;
     ReportSizingManager::RequestSizing(state, CompType, CompName, SizingMethod, SizingString, TempSize, PrintFlag, RoutineName);
     this->ratedEvapAirFlowRate = TempSize;
     Real64 const ratedInletAirTemp(26.6667);        // 26.6667C or 80F
     Real64 const ratedInletAirHumRat(0.0111847); // Humidity ratio corresponding to 80F dry bulb/67F wet bulb
+    DataSizing::DataEMSOverrideON = false;
+    DataSizing::DataEMSOverride = 0.0;
     this->ratedEvapAirMassFlowRate = this->ratedEvapAirFlowRate * Psychrometrics::PsyRhoAirFnPbTdbW(
             DataEnvironment::StdBaroPress, ratedInletAirTemp, ratedInletAirHumRat, RoutineName);
 
     SizingMethod = DataHVACGlobals::CoolingCapacitySizing;
+    DataSizing::DataEMSOverrideON = this->ratedTotCapFlowEMSOverrideON;
+    DataSizing::DataEMSOverride = this->ratedTotCapFlowEMSOverrideValue;
     SizingString = "Rated Gross Total Cooling Capacity [W]";
-    DataSizing::DataFlowUsedForSizing = this->ratedEvapAirFlowRate; // TODO: This is volume flow, right?
+    DataSizing::DataFlowUsedForSizing = this->ratedEvapAirFlowRate;
     TempSize = this->original_input_specs.gross_rated_total_cooling_capacity;
     ReportSizingManager::RequestSizing(state, CompType, CompName, SizingMethod, SizingString, TempSize, PrintFlag, RoutineName);
+    DataSizing::DataEMSOverrideON = false;
+    DataSizing::DataEMSOverride = 0.0;
     this->ratedGrossTotalCap = TempSize;
 
     SizingMethod = DataHVACGlobals::AutoCalculateSizing;
@@ -183,7 +222,11 @@ void CoilCoolingDXCurveFitOperatingMode::size(EnergyPlusData &state)
     SizingString = "Rated Condenser Air Flow Rate [m3/s]";
     TempSize = this->original_input_specs.rated_condenser_air_flow_rate;
     ReportSizingManager::RequestSizing(state, CompType, CompName, SizingMethod, SizingString, TempSize, PrintFlag, RoutineName);
+    DataSizing::DataConstantUsedForSizing = 0.0;
+    DataSizing::DataFractionUsedForSizing = 0.0;
     this->ratedCondAirFlowRate = TempSize;
+    int numSpeeds = this->speeds.size();
+    int thisSpeedNum = 0;
 
 
     if (this->condenserType != AIRCOOLED) {
@@ -198,10 +241,27 @@ void CoilCoolingDXCurveFitOperatingMode::size(EnergyPlusData &state)
     }
 
     for (auto &curSpeed : this->speeds) {
+        curSpeed.parentName = this->parentName;
         curSpeed.parentModeRatedGrossTotalCap = this->ratedGrossTotalCap;
+        curSpeed.ratedGrossTotalCapIsAutosized = this->ratedGrossTotalCapIsAutosized;
         curSpeed.parentModeRatedEvapAirFlowRate = this->ratedEvapAirFlowRate;
+        curSpeed.ratedEvapAirFlowRateIsAutosized = this->ratedEvapAirFlowRateIsAutosized;
         curSpeed.parentModeRatedCondAirFlowRate = this->ratedCondAirFlowRate;
-        curSpeed.size(state);
+
+        // Set latent degradation parameters if applicable
+        curSpeed.doLatentDegradation = false;
+        if (this->latentDegradationActive) {
+            if ((thisSpeedNum == 0) || ((thisSpeedNum > 0) && this->applyLatentDegradationAllSpeeds)) {
+                curSpeed.parentModeTimeForCondensateRemoval = this->timeForCondensateRemoval;
+                curSpeed.parentModeEvapRateRatio = this->evapRateRatio;
+                curSpeed.parentModeMaxCyclingRate = this->maxCyclingRate;
+                curSpeed.parentModeLatentTimeConst = this->latentTimeConst;
+                curSpeed.doLatentDegradation = true;
+            }
+        }
+
+        curSpeed.size(state, thisSpeedNum, numSpeeds);
+        thisSpeedNum++;
     }
 }
 
@@ -211,9 +271,10 @@ void CoilCoolingDXCurveFitOperatingMode::CalcOperatingMode(EnergyPlusData &state
                                                            Real64 &PLR,
                                                            int &speedNum,
                                                            Real64 &speedRatio,
-                                                           int &fanOpMode,
+                                                           int  const fanOpMode,
                                                            DataLoopNode::NodeData &condInletNode,
-                                                           DataLoopNode::NodeData &EP_UNUSED(condOutletNode))
+                                                           DataLoopNode::NodeData &EP_UNUSED(condOutletNode),
+                                                           bool const singleMode)
 {
 
     // Currently speedNum is 1-based, while this->speeds are zero-based
@@ -226,20 +287,21 @@ void CoilCoolingDXCurveFitOperatingMode::CalcOperatingMode(EnergyPlusData &state
             condInletNode.Temp, condInletNode.HumRat, DataEnvironment::StdPressureSeaLevel, "CoilCoolingDXCurveFitOperatingMode::CalcOperatingMode");
     }
     // thisspeed.ambPressure = inletNode.Press;
-    thisspeed.ambPressure = DataEnvironment::OutBaroPress;
+    thisspeed.ambPressure = condInletNode.Press;
     thisspeed.AirMassFlow = inletNode.MassFlowRate;
     if (fanOpMode == DataHVACGlobals::CycFanCycCoil && speedNum == 1) {
         if (PLR > 0.0) {
-            thisspeed.AirMassFlow = inletNode.MassFlowRate / PLR;
+            thisspeed.AirMassFlow = thisspeed.AirMassFlow / PLR;
         } else {
             thisspeed.AirMassFlow = 0.0;
         }
     } else if (speedNum > 1) {
         thisspeed.AirMassFlow = DataHVACGlobals::MSHPMassFlowRateHigh;
     }
+    // rated flow rate is adjusted by coil face area fraction so adjustment is before next IF
+    thisspeed.AirMassFlow *= thisspeed.active_fraction_of_face_coil_area;
     if (thisspeed.RatedAirMassFlowRate > 0.0) {
-        // TODO: The original two-speed just grabbed the RatedAirMassFlowRate(mode1), not for a specific speed, so that's what I'll do too
-        thisspeed.AirFF = thisspeed.AirMassFlow / this->ratedEvapAirMassFlowRate;  //thisspeed.RatedAirMassFlowRate;
+        thisspeed.AirFF = thisspeed.AirMassFlow / thisspeed.RatedAirMassFlowRate;
     } else {
         thisspeed.AirFF = 0.0;
     }
@@ -252,6 +314,24 @@ void CoilCoolingDXCurveFitOperatingMode::CalcOperatingMode(EnergyPlusData &state
 
     thisspeed.CalcSpeedOutput(state, inletNode, outletNode, plr1, fanOpMode, this->condInletTemp);
 
+    // the outlet node conditions are based on it running at the truncated flow, we need to merge the bypassed air back in and ramp up flow rate
+    if (thisspeed.adjustForFaceArea) {
+        thisspeed.AirMassFlow /= thisspeed.active_fraction_of_face_coil_area;
+        Real64 correctedEnthalpy = (1.0 - thisspeed.active_fraction_of_face_coil_area) * inletNode.Enthalpy +
+                                   thisspeed.active_fraction_of_face_coil_area * outletNode.Enthalpy;
+        Real64 correctedHumRat =
+            (1.0 - thisspeed.active_fraction_of_face_coil_area) * inletNode.HumRat + thisspeed.active_fraction_of_face_coil_area * outletNode.HumRat;
+        Real64 correctedTemp = Psychrometrics::PsyTdbFnHW(correctedEnthalpy, correctedHumRat);
+        // Check for saturation error and modify temperature at constant enthalpy
+        //    if (correctedTemp < Psychrometrics::PsyTsatFnHPb(correctedEnthalpy, inletNode.Press)) {
+        //        correctedTemp = Psychrometrics::PsyTsatFnHPb(correctedEnthalpy, inletNode.Press);
+        //        correctedHumRat = Psychrometrics::PsyWFnTdbH(correctedTemp, correctedEnthalpy);
+        //    }
+        outletNode.Temp = correctedTemp;
+        outletNode.HumRat = correctedHumRat;
+        outletNode.Enthalpy = correctedEnthalpy;
+    }
+
     Real64 outSpeed1HumRat = outletNode.HumRat;
     Real64 outSpeed1Enthalpy = outletNode.Enthalpy;
 
@@ -265,19 +345,38 @@ void CoilCoolingDXCurveFitOperatingMode::CalcOperatingMode(EnergyPlusData &state
     OpModePower = thisspeed.fullLoadPower * thisspeed.RTF;
     OpModeWasteHeat = thisspeed.fullLoadWasteHeat * thisspeed.RTF;
 
-    if ((speedNum > 1) && (speedRatio < 1.0)) {
+    if ((speedNum > 1) && (speedRatio < 1.0) && !singleMode) {
 
         // If multispeed, evaluate next lower speed using PLR, then combine with high speed for final outlet conditions
         auto &lowerspeed(this->speeds[max(speedNum - 2, 0)]);
-        lowerspeed.AirMassFlow = DataHVACGlobals::MSHPMassFlowRateLow;
+        lowerspeed.AirMassFlow = DataHVACGlobals::MSHPMassFlowRateLow * lowerspeed.active_fraction_of_face_coil_area;
 
         lowerspeed.CalcSpeedOutput(state, inletNode, outletNode, PLR, fanOpMode, condInletTemp); // out
 
+        if (lowerspeed.adjustForFaceArea) {
+            lowerspeed.AirMassFlow /= lowerspeed.active_fraction_of_face_coil_area;
+            Real64 correctedEnthalpy = (1.0 - lowerspeed.active_fraction_of_face_coil_area) * inletNode.Enthalpy +
+                                       lowerspeed.active_fraction_of_face_coil_area * outletNode.Enthalpy;
+            Real64 correctedHumRat = (1.0 - lowerspeed.active_fraction_of_face_coil_area) * inletNode.HumRat +
+                                     lowerspeed.active_fraction_of_face_coil_area * outletNode.HumRat;
+            Real64 correctedTemp = Psychrometrics::PsyTdbFnHW(correctedEnthalpy, correctedHumRat);
+            // Check for saturation error and modify temperature at constant enthalpy
+            //        if (correctedTemp < Psychrometrics::PsyTsatFnHPb(correctedEnthalpy, inletNode.Press)) {
+            //            correctedTemp = Psychrometrics::PsyTsatFnHPb(correctedEnthalpy, inletNode.Press);
+            //            correctedHumRat = Psychrometrics::PsyWFnTdbH(correctedTemp, correctedEnthalpy);
+            //        }
+            outletNode.Temp = correctedTemp;
+            outletNode.HumRat = correctedHumRat;
+            outletNode.Enthalpy = correctedEnthalpy;
+        }
+
         outletNode.HumRat = outSpeed1HumRat * speedRatio + (1.0 - speedRatio) * outletNode.HumRat;
         outletNode.Enthalpy = outSpeed1Enthalpy * speedRatio + (1.0 - speedRatio) * outletNode.Enthalpy;
         outletNode.Temp = Psychrometrics::PsyTdbFnHW(outletNode.Enthalpy, outletNode.HumRat);
-        OpModePower = OpModePower + (1.0 - thisspeed.RTF) * lowerspeed.fullLoadPower;
-        OpModeWasteHeat = OpModeWasteHeat + (1.0 - thisspeed.RTF) * lowerspeed.fullLoadWasteHeat;
+
+        this->OpModePower += (1.0 - thisspeed.RTF) * lowerspeed.fullLoadPower;
+        this->OpModeWasteHeat += (1.0 - thisspeed.RTF) * lowerspeed.fullLoadWasteHeat;
+        this->OpModeRTF = 1.0; // if we are on greater than 1 speed, RTF *must* be 1
     }
 }