Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unitary system now reports warning when cycling supply fan schedule is used with setpoint control type #8323

Merged
merged 14 commits into from
Nov 2, 2020
Merged

Unitary system now reports warning when cycling supply fan schedule is used with setpoint control type #8323

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0ed4d98
Add if statement for SolveRoot method and PartLoadRatio calculation.
matthew-larson Sep 17, 2020
0e3b305
Revert code change and add unit test for issue.
matthew-larson Sep 21, 2020
2be3bd9
Merge branch 'develop' of https://github.com/nrel/energyplus into uni…
matthew-larson Sep 21, 2020
4f7867b
Modify fix location and unit test.
matthew-larson Sep 23, 2020
0720d0b
Merge branch 'develop' of https://github.com/nrel/energyplus into uni…
matthew-larson Sep 23, 2020
103f793
Merge branch 'develop' of https://github.com/nrel/energyplus into uni…
matthew-larson Sep 29, 2020
f44e97a
Merge branch 'develop' of https://github.com/nrel/energyplus into uni…
matthew-larson Sep 30, 2020
cfbb9fc
Merge fan operating mode if statement into InitUnitarySystems.
matthew-larson Sep 30, 2020
ab1959d
Merge branch 'develop' of https://github.com/nrel/energyplus into uni…
matthew-larson Oct 15, 2020
66cbd81
Move code fix to first iteration only and add line feed and end of un…
matthew-larson Oct 15, 2020
5bb0670
Fix unit test from develop changes.
matthew-larson Oct 15, 2020
1b8e318
Merge branch 'develop' of https://github.com/nrel/energyplus into uni…
matthew-larson Oct 28, 2020
9d2ed69
Change fix to provide correct error message for cycling fan with setp…
matthew-larson Oct 29, 2020
2138fb1
Update unit test for error checking of cycling fan with setpoint cont…
matthew-larson Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/EnergyPlus/UnitarySystem.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7996,6 +7996,15 @@ namespace UnitarySystems {
}
this->m_DesiredOutletTemp = min(this->m_DesiredOutletTemp, MaxOutletTemp);

if (this->m_FanOpModeSchedPtr > 0) {
if (ScheduleManager::GetCurrentScheduleValue(this->m_FanOpModeSchedPtr) == 0.0) {
this->m_FanOpMode = DataHVACGlobals::CycFanCycCoil;
} else {
this->m_FanOpMode = DataHVACGlobals::ContFanCycCoil;
DataHVACGlobals::OnOffFanPartLoadFraction = 1.0;
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this works but now this same code is in 2 places, here and in initLoadBasedControl. Shouldn't these get moved to initUnitarySystems inside the FirstHVACIteration test (line 1084) so that both control types execute this, it's only done once per time step and there is only 1 copy of these lines of code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, I'll make this adjustment once the CI finishes. Thanks

} else {
// should never get here, only 3 control types
}
Expand Down
231 changes: 231 additions & 0 deletions tst/EnergyPlus/unit/UnitarySystem.unit.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15406,3 +15406,234 @@ TEST_F(ZoneUnitarySysTest, UnitarySystemModel_MultiSpeedDXCoilsDirectSolutionTes
EXPECT_NEAR(thisSys->m_SpeedRatio, 0.228062, 0.02);
EXPECT_NEAR(sensOut, -11998.0, 210.0);
}

TEST_F(ZoneUnitarySysTest, UnitarySystemModel_SingleSpeedDXCoolCoil_Only)
{

std::string const idf_objects = delimited_string({

"AirLoopHVAC:UnitarySystem,",
" Unitary System Model, !- Name",
" Setpoint, !- Control Type",
" East Zone, !- Controlling Zone or Thermostat Location",
" None, !- Dehumidification Control Type",
" AlwaysOne, !- Availability Schedule Name",
" Zone Exhaust Node, !- Air Inlet Node Name",
" Zone 2 Inlet Node, !- Air Outlet Node Name",
" Fan:OnOff, !- Supply Fan Object Type",
" Supply Fan 1, !- Supply Fan Name",
" BlowThrough, !- Fan Placement",
" AlwaysZero, !- Supply Air Fan Operating Mode Schedule Name",
" , !- Heating Coil Object Type",
" , !- Heating Coil Name",
" , !- DX Heating Coil Sizing Ratio",
" Coil:Cooling:DX:SingleSpeed, !- Cooling Coil Object Type",
" DX Cooling Coil, !- Cooling Coil Name",
" No, !- Use DOAS DX Cooling Coil",
" 2.0, !- DOAS DX Cooling Coil Leaving Minimum Air Temperature{ C }",
" SensibleOnlyLoadControl, !- Latent Load Control",
" , !- Supplemental Heating Coil Object Type",
" , !- Supplemental Heating Coil Name",
" , !- Supply Air Flow Rate Method During Cooling Operation",
" autosize, !- Supply Air Flow Rate During Cooling Operation{ m3/s }",
" , !- Supply Air Flow Rate Per Floor Area During Cooling Operation{ m3/s-m2 }",
" , !- Fraction of Autosized Design Cooling Supply Air Flow Rate",
" , !- Design Supply Air Flow Rate Per Unit of Capacity During Cooling Operation{ m3/s-W }",
" , !- Supply air Flow Rate Method During Heating Operation",
" autosize, !- Supply Air Flow Rate During Heating Operation{ m3/s }",
" , !- Supply Air Flow Rate Per Floor Area during Heating Operation{ m3/s-m2 }",
" , !- Fraction of Autosized Design Heating Supply Air Flow Rate",
" , !- Design Supply Air Flow Rate Per Unit of Capacity During Heating Operation{ m3/s-W }",
" , !- Supply Air Flow Rate Method When No Cooling or Heating is Required",
" autosize, !- Supply Air Flow Rate When No Cooling or Heating is Required{ m3/s }",
" , !- Supply Air Flow Rate Per Floor Area When No Cooling or Heating is Required{ m3/s-m2 }",
" , !- Fraction of Autosized Design Cooling Supply Air Flow Rate",
" , !- Fraction of Autosized Design Heating Supply Air Flow Rate",
" , !- Design Supply Air Flow Rate Per Unit of Capacity During Cooling Operation{ m3/s-W }",
" , !- Design Supply Air Flow Rate Per Unit of Capacity During Heating Operation{ m3/s-W }",
" 80.0; !- Maximum Supply Air Temperature{ C }",

"Fan:OnOff,",
" Supply Fan 1, !- Name",
" AlwaysOne, !- Availability Schedule Name",
" 0.7, !- Fan Total Efficiency",
" 600.0, !- Pressure Rise{ Pa }",
" autosize, !- Maximum Flow Rate{ m3 / s }",
" 0.9, !- Motor Efficiency",
" 1.0, !- Motor In Airstream Fraction",
" Zone Exhaust Node, !- Air Inlet Node Name",
" Cooling Coil Air Inlet Node; !- Air Outlet Node Name",

"Coil:Cooling:DX:SingleSpeed,",
" DX Cooling Coil, !- Name",
" , !- Availability Schedule Name",
" autosize, !- Gross Rated Total Cooling Capacity{ W }",
" 0.8, !- Gross Rated Sensible Heat Ratio",
" 3.0, !- Gross Rated Cooling COP{ W / W }",
" autosize, !- Rated Air Flow Rate {m3/s}",
" , !- Rated Evaporator Fan Power Per Volume Flow Rate {W/(m3/s)}",
" Cooling Coil Air Inlet Node, !- Air Inlet Node Name",
" Zone 2 Inlet Node, !- Air Outlet Node Name",
" Biquadratic, !- Total Cooling Capacity Function of Temperature Curve Name",
" Quadratic, !- Total Cooling Capacity Function of Flow Fraction Curve Name",
" Biquadratic, !- Energy Input Ratio Function of Temperature Curve Name",
" Quadratic, !- Energy Input Ratio Function of Flow Fraction Curve Name",
" Quadratic, !- Part Load Fraction Correlation Curve Name",
" -25.0, !- Minimum Outdoor Dry-Bulb Temperature for Compressor Operation {C}",
" 1000, !- Nominal Time for Condensate Removal to Begin {s}",
" 1.5, !- Ratio of Initial Moisture Evaporation Rate and Steady State Latent Capacity {dimensionless}",
" 3, !- Maximum Cycling Rate {cycles/hr}",
" 45, !- Latent Capacity Time Constant {s}",
" , !- Condenser Air Inlet Node Name",
" EvaporativelyCooled; !- Condenser Type",

"ScheduleTypeLimits,",
" Any Number; !- Name",

"Schedule:Compact,",
" AlwaysOne, !- Name",
" Any Number, !- Schedule Type Limits Name",
" Through: 12/31, !- Field 1",
" For: AllDays, !- Field 2",
" Until: 24:00, 1.0; !- Field 3",

"Schedule:Compact,",
" AlwaysZero, !- Name",
" Any Number, !- Schedule Type Limits Name",
" Through: 12/31, !- Field 1",
" For: AllDays, !- Field 2",
" Until: 24:00, 0.0; !- Field 3",

"Schedule:Compact,",
" Always 20C, !- Name",
" Any Number, !- Schedule Type Limits Name",
" Through: 12/31, !- Field 1",
" For: AllDays, !- Field 2",
" Until: 24:00, 20.0; !- Field 3",

"SetpointManager:Scheduled,",
" Cooling Coil Setpoint Manager, !- Name",
" Temperature, !- Control Variable",
" Always 20C, !- Schedule Name",
" Zone 2 Inlet Node; !- Setpoint Node or NodeList Name",

"Curve:Quadratic,",
" Quadratic, !- Name",
" 0.8, !- Coefficient1 Constant",
" 0.2, !- Coefficient2 x",
" 0.0, !- Coefficient3 x**2",
" 0.5, !- Minimum Value of x",
" 1.5; !- Maximum Value of x",

"Curve:Biquadratic,",
" Biquadratic, !- Name",
" 0.942587793, !- Coefficient1 Constant",
" 0.009543347, !- Coefficient2 x",
" 0.000683770, !- Coefficient3 x**2",
" -0.011042676, !- Coefficient4 y",
" 0.000005249, !- Coefficient5 y**2",
" -0.000009720, !- Coefficient6 x*y",
" 12.77778, !- Minimum Value of x",
" 23.88889, !- Maximum Value of x",
" 18.0, !- Minimum Value of y",
" 46.11111, !- Maximum Value of y",
" , !- Minimum Curve Output",
" , !- Maximum Curve Output",
" Temperature, !- Input Unit Type for X",
" Temperature, !- Input Unit Type for Y",
" Dimensionless; !- Output Unit Type",

});

ASSERT_TRUE(process_idf(idf_objects)); // read idf objects

// call the UnitarySystem factory
std::string compName = "UNITARY SYSTEM MODEL";
bool zoneEquipment = true;
bool FirstHVACIteration = true;
UnitarySystems::UnitarySys::factory(state, DataHVACGlobals::UnitarySys_AnyCoilType, compName, zoneEquipment, 0);
UnitarySystems::UnitarySys *thisSys = &UnitarySystems::unitarySys[0];

DataZoneEquipment::ZoneEquipInputsFilled = true; // indicate zone data is available
thisSys->getUnitarySystemInputData(state, compName, zoneEquipment, 0, ErrorsFound); // get UnitarySystem input from object above
EXPECT_FALSE(ErrorsFound); // expect no errors

OutputReportPredefined::SetPredefinedTables();

// UnitarySystem used as zone equipment will not be modeled when FirstHAVCIteration is true, first time FirstHVACIteration = false will disable
// the 'return' on FirstHVACIteration = true set FirstHVACIteration to false for unit testing to size water coils
FirstHVACIteration = false;
DataGlobals::BeginEnvrnFlag = false;

// overwrite outdoor weather temp to variable speed coil rated water temp until this gets fixed
DataSizing::DesDayWeath(1).Temp(1) = 29.4;

// test #6274 where coil inlet air flow rate was non-zero prior to sizing
// this simulates another UnitarySystem upstream of this UnitarySystem that ran before this system coil was sized (and placed a non-zero air flow
// rate on this system's inlet node)
DataLoopNode::Node(thisSys->CoolCoilInletNodeNum).MassFlowRate = 0.05;

int AirLoopNum = 0;
int CompIndex = 1;
bool HeatActive = false;
bool CoolActive = true;
int const ZoneOAUnitNum = 0;
Real64 const OAUCoilOutTemp = 0.0;
bool const ZoneEquipment = true;
Real64 sensOut = 0.0;
Real64 latOut = 0.0;

thisSys->simulate(state,
thisSys->Name,
FirstHVACIteration,
AirLoopNum,
CompIndex,
HeatActive,
CoolActive,
ZoneOAUnitNum,
OAUCoilOutTemp,
ZoneEquipment,
sensOut,
latOut);

// set up node conditions to test UnitarySystem set point based control
// Unitary system air inlet node = 1
DataLoopNode::Node(1).MassFlowRate = thisSys->m_DesignMassFlowRate;
DataLoopNode::Node(1).MassFlowRateMaxAvail = thisSys->m_DesignMassFlowRate; // max avail at fan inlet so fan won't limit flow

// test COOLING condition
DataLoopNode::Node(1).Temp = 24.0; // 24C db
DataLoopNode::Node(1).HumRat = 0.00922; // 17C wb
DataLoopNode::Node(1).Enthalpy = 47597.03; // www.sugartech.com/psychro/index.php

ScheduleManager::ProcessScheduleInput(state.files); // read schedules

// Cooling coil air inlet node = 3
DataLoopNode::Node(3).MassFlowRateMax = thisSys->m_DesignMassFlowRate; // max at fan outlet so fan won't limit flow
// Cooling coil air outlet node = 2
DataLoopNode::Node(2).TempSetPoint = 17.0;

ScheduleManager::Schedule(1).CurrentValue = 1.0; // Enable schedule without calling schedule manager

DataGlobals::BeginEnvrnFlag = true; // act as if simulation is beginning

// COOLING mode
thisSys->simulate(state,
thisSys->Name,
FirstHVACIteration,
AirLoopNum,
CompIndex,
HeatActive,
CoolActive,
ZoneOAUnitNum,
OAUCoilOutTemp,
ZoneEquipment,
sensOut,
latOut);

EXPECT_NEAR(thisSys->m_CompPartLoadRatio, 0.35, 0.001);
// check that cooling coil air outlet node is at set point
EXPECT_NEAR(DataLoopNode::Node(2).Temp, DataLoopNode::Node(2).TempSetPoint, 0.001);
// cooling coil air inlet node temp is greater than cooling coil air outlet node temp
EXPECT_GT(DataLoopNode::Node(3).Temp, DataLoopNode::Node(2).Temp);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoot, this was ready to merge. Line feed needed at end of unit test.