Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the license year to 2021 #8445

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Update the license year to 2021 #8445

merged 1 commit into from
Jan 14, 2021

Conversation

jasondegraw
Copy link
Member

Pull request overview

Update the license year to 2021. There's a growing number of Python files in the repo, mostly without any license markings. We probably should change that at some point.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jasondegraw jasondegraw added the DoNotPublish Includes changes that shouldn't be reported in the changelog label Jan 3, 2021
@jasondegraw jasondegraw added this to the EnergyPlus 9.5.0 milestone Jan 3, 2021
@Myoldmopar
Copy link
Member

Thanks @jasondegraw, and I agree. Do you want to modify the license search script to enforce the Python files we've added? I'm happy to do it but as you authored that stuff I'm happy to let you make the changes too. #8442 just hit the license year issue after an innocent merge from develop 😄

@jasondegraw
Copy link
Member Author

@Myoldmopar I'd prefer to do it, there are a few things in the current scripts that could probably use some cleanup. There probably isn't too much to discuss beyond what might need to be excluded, but just in case I'll create a separate issue later today.

@Myoldmopar
Copy link
Member

OK, this one is ready to go in, I'll add some changes to #8469 and then that can go in and we'll be in great shape with the license checking. Thanks @jasondegraw !

@Myoldmopar Myoldmopar merged commit a9778ba into develop Jan 14, 2021
@Myoldmopar Myoldmopar deleted the update-license-year branch January 14, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DoNotPublish Includes changes that shouldn't be reported in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants