Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Thermal Comfort zone temperature and humidity lag #8572

Merged
merged 16 commits into from
Mar 21, 2021
Merged

Fix Thermal Comfort zone temperature and humidity lag #8572

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
56036e9
Thermal comfort calc air temeprature update correction. Compiles ok.
jcyuan2020 Feb 6, 2021
cf570ee
Merge remote-tracking branch 'upstream/develop' into Thermal_Comfort_…
jcyuan2020 Feb 6, 2021
af70151
Merge remote-tracking branch 'upstream/develop' into Thermal_Comfort_…
jcyuan2020 Feb 26, 2021
a16aed5
Unit test development.
jcyuan2020 Feb 26, 2021
36f7229
Merge remote-tracking branch 'upstream/develop' into Thermal_Comfort_…
jcyuan2020 Mar 3, 2021
c784193
Merge remote-tracking branch 'upstream/develop' into Thermal_Comfort_…
jcyuan2020 Mar 4, 2021
2e4c43e
Merge remote-tracking branch 'upstream/develop' into Thermal_Comfort_…
jcyuan2020 Mar 4, 2021
0a539f5
2021-03-05: Resolve merge conflicts brought by dataHeatBalFanSys stat…
jcyuan2020 Mar 5, 2021
827220f
Revise unit test to accomonadate state variable change.
jcyuan2020 Mar 5, 2021
6cb4b32
Add additional changes to solve temp and humid synchronization.
jcyuan2020 Mar 5, 2021
e561423
Update unit test for synchronization code revisions.
jcyuan2020 Mar 5, 2021
db8285f
Merge remote-tracking branch 'upstream/develop' into Thermal_Comfort_…
jcyuan2020 Mar 6, 2021
6985e48
Merge remote-tracking branch 'upstream/develop' into Thermal_Comfort_…
jcyuan2020 Mar 16, 2021
434adb3
Remove redudant commented code lines.
jcyuan2020 Mar 16, 2021
3a1df8e
Merge remote-tracking branch 'upstream/develop' into Thermal_Comfort_…
jcyuan2020 Mar 17, 2021
b20eb5c
2021-03-19 Resolved conflicts when merging upstream develop. Took cha…
jcyuan2020 Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/EnergyPlus/HVACManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,8 @@ namespace EnergyPlus::HVACManager {

state.dataHeatBalFanSys->ZT = state.dataHeatBalFanSys->MAT;
// save for use with thermal comfort control models (Fang, Pierce, and KSU)
state.dataHeatBalFanSys->ZTAVComf = state.dataHeatBalFanSys->ZTAV;
state.dataHeatBalFanSys->ZoneAirHumRatAvgComf = state.dataHeatBalFanSys->ZoneAirHumRatAvg;
// state.dataHeatBalFanSys->ZTAVComf = state.dataHeatBalFanSys->ZTAV;
// state.dataHeatBalFanSys->ZoneAirHumRatAvgComf = state.dataHeatBalFanSys->ZoneAirHumRatAvg;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcyuan2020 These lines should be deleted instead of commented, but otherwise, I'm good with this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjwitte The redundant commented code lines are now removed.

state.dataHeatBalFanSys->ZTAV = 0.0;
state.dataHeatBalFanSys->ZoneThermostatSetPointHiAver = 0.0;
state.dataHeatBalFanSys->ZoneThermostatSetPointLoAver = 0.0;
Expand Down Expand Up @@ -530,6 +530,9 @@ namespace EnergyPlus::HVACManager {
FirstTimeStepSysFlag = false;
} // system time step loop (loops once if no downstepping)

state.dataHeatBalFanSys->ZTAVComf = state.dataHeatBalFanSys->ZTAV;
state.dataHeatBalFanSys->ZoneAirHumRatAvgComf = state.dataHeatBalFanSys->ZoneAirHumRatAvg;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change to make such an impact. But it seems reasonable, and analysis of the diffs shows better results. This is fine.

ManageZoneAirUpdates(state, iPushZoneTimestepHistories, ZoneTempChange, ShortenTimeStepSys, UseZoneTimeStepHistory, PriorTimeStep);
if (state.dataContaminantBalance->Contaminant.SimulateContaminants)
ManageZoneContaminanUpdates(state, iPushZoneTimestepHistories, ShortenTimeStepSys, UseZoneTimeStepHistory, PriorTimeStep);
Expand Down
Loading