Skip to content

Commit

Permalink
Update some comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
joseph-robertson committed Jun 7, 2024
1 parent eb2ab10 commit 17d344f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
7 changes: 0 additions & 7 deletions src/utilities/filetypes/EpwFile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3962,13 +3962,6 @@ bool EpwFile::parse(std::istream& ifs, bool storeData) {
}
epw_string epw_s = {lineNumber, year, month, day, hour, currentMinute, strings};
epw_strings.push_back(epw_s);
/* boost::optional<EpwDataPoint> pt = EpwDataPoint::fromEpwStrings(year, month, day, hour, currentMinute, strings); */
/* if (pt) {
m_data.push_back(pt.get());
} else {
LOG(Error, "Failed to parse line " << lineNumber << " of EPW file '" << m_path << "'");
return false;
} */
}

} catch (...) {
Expand Down
4 changes: 2 additions & 2 deletions src/utilities/filetypes/test/EpwFile_GTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ TEST(Filetypes, EpwFile_LeapTimeSeries_AMYNoLeapDay) {
boost::optional<TimeSeries> _t;
ASSERT_NO_THROW(_t = epwFile.getTimeSeries("Dry Bulb Temperature"));
ASSERT_TRUE(_t);
// even though this is AMY, the lack of Feb29 causes it to be TMY
// even though this is AMY, the lack of Feb 29 causes it to be TMY (i.e., successive datapoints greater than 1 day)
boost::optional<int> _timeSeriesBaseYear = _t->firstReportDateTime().date().baseYear();
EXPECT_FALSE(_timeSeriesBaseYear);
} catch (...) {
Expand Down Expand Up @@ -565,7 +565,7 @@ TEST(Filetypes, EpwFile_LeapTimeSeries_TMYLeapFebLeapDay) {
EpwFile epwFile(p);
boost::optional<TimeSeries> _t;
_t = epwFile.getTimeSeries("Dry Bulb Temperature");
ASSERT_TRUE(false);
ASSERT_TRUE(false); // we don't hit this because we expect getTimeSeries to fail
} catch (...) {
ASSERT_TRUE(true);
}
Expand Down

0 comments on commit 17d344f

Please sign in to comment.