-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android platform support #40
Conversation
Signed-off-by: moraaar <moraaar@amazon.com>
Signed-off-by: moraaar <moraaar@amazon.com>
Signed-off-by: moraaar <moraaar@amazon.com>
Signed-off-by: moraaar <moraaar@amazon.com>
Signed-off-by: moraaar <moraaar@amazon.com>
Signed-off-by: moraaar <moraaar@amazon.com>
…e libraries to be correctly named with the suffix _64, the same as all the other platforms. Signed-off-by: moraaar <moraaar@amazon.com>
@@ -76,15 +76,15 @@ struct MTorqueCurveProperty : public PxFixedSizeLookupTablePropertyInfo<PxVehicl | |||
PX_PHYSX_CORE_API MTorqueCurveProperty(); | |||
}; | |||
|
|||
#if PX_CLANG | |||
#if PX_LINUX && PX_CLANG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this check be !PX_ANDROID
, since this code may be applicable for other supported clang platforms(MacOS and Switch)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the other places in the code base doing ignored "-Wreserved-identifier"
are using #if PX_LINUX && PX_CLANG
, this was the only one not to, so for consistency I followed the same pattern. And all the platforms built correctly like this.
Android platform support has been submitted to the following PhysX fork where it will be maintained: https://github.com/o3de/PhysX For more details see the following discussion: #58 |
What's new?
android-arm64-v8a
added. Initial support focused on 64-bit arm8 architecture with NEON SIMD instructions.Out of Scope
The following points are considered out of scope, they can be added in the future:
Known Errors/Limitations
bin\UNKNOWN
. To fix this nVidia has to modify the CMakeModules package it's downloaded from packman when building PhysX. The file that needs to be modified isGetCompilerAndPlatform.cmake
, adding the following lines to theif
condition insideGetPlatformBinName
function:Testing
PX_GENERATE_STATIC_LIBRARIES
set to both true and false. The right output binaries were generated inbin/android.arm64-v8a
install
target successfully. It generated the correct output for Android underinstall/android-29
folder, only including necessary headers for Android.Open 3D Engine (O3DE)
with an early integration branch. The following video shows O3DE running PhysX 5.1 on Android.https://user-images.githubusercontent.com/27999040/203624867-6ed19905-d0dc-4dfe-943a-46e584fd9983.mp4
Signed-off-by: moraaar moraaar@amazon.com