Adjust test epsilons #5642
Open
Adjust test epsilons #5642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzient
commented
Sep 20, 2024
Comment on lines
447
to
451
| // Epsilons are quite big because: | ||
| // - GPU uses fma | ||
| // - GPU uses different rounding | ||
| // - processing order in the reference is forced to be XYZ or YXZ, whereas | ||
| // the tested implementation can use any order. |
There was a problem hiding this comment.
The comments were swapped between CPU and GPU functions.
|
CI MESSAGE: [18580895]: BUILD STARTED |
JanuszL
approved these changes
Sep 20, 2024
JanuszL
changed the title
|
CI MESSAGE: [18580895]: BUILD FAILED |
|
CI MESSAGE: [18580895]: BUILD PASSED |
mzient
force-pushed
the
adjust_resampling_test_eps
branch
from
117f1c5
to
af4ded2
Compare
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
mzient
force-pushed
the
adjust_resampling_test_eps
branch
from
af4ded2
to
9a47ec8
Compare
|
CI MESSAGE: [18644546]: BUILD STARTED |
|
CI MESSAGE: [18644546]: BUILD PASSED |
banasraf
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other (e.g. Documentation, Tests, Configuration)
Test
Description:
Separable resampling 3D test doesn't pass on some devices. This PR adjusts the threshold values.
Additional information:
Affected modules and functionalities:
Tests.
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A