Add DataNode.shape() #5648
Open
Add DataNode.shape() #5648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
CI MESSAGE: [18775471]: BUILD STARTED |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
CI MESSAGE: [18775471]: BUILD PASSED |
mdabek-nvidia
approved these changes
Sep 27, 2024
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
CI MESSAGE: [18879002]: BUILD STARTED |
klecki
approved these changes
Sep 30, 2024
klecki
reviewed
Sep 30, 2024
| self._check_gpu2cpu() | ||
| return fn.shapes(self, dtype=dtype, device=device) | ||
|
|
||
| def _check_gpu2cpu(self): |
There was a problem hiding this comment.
Can you add a docstring here where this should be used? And maybe a warning why we don't use current_pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Description:
This PR adds a
shape()function to the DataNode. By default, this function returns the result of callingfn.shapes(node, device="cpu").It also improves gpu2cpu check - for
.cpu()function, calling it earlier in the process if there's a "current" pipeline available (previously it would be checked at build time).Additional information:
Affected modules and functionalities:
Pipeline
DataNode
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-4073