Metadata accessor #5650
Open
Metadata accessor #5650
+211
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -15,7 +15,8 @@ | |||
| from nvidia.dali import pipeline_def | |||
| import os | |||
| import numpy as np | |||
| from nvidia.dali import fn | |||
| import nvidia.dali as dali | |||
Check notice
Code scanning / CodeQL
Module is imported with 'import' and 'import from' Note test
| return to_cpu(gpu) | ||
|
|
||
| with assert_raises(RuntimeError, glob="doesn't support transition from GPU to CPU"): | ||
| pipe = pdef(lambda gpu: gpu.cpu()) # this will raise an error at construction time |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
This PR reimplements GetProperty to allow for:
It also introduces
DataNode.metadatafunction and a shortcut forsource_info.NOTE
layoutdoesn't get a dedicated accessor, since we want to have a static (build-time) layout and dtype.Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A