Skip to content

Commit

Permalink
Undo no-need change
Browse files Browse the repository at this point in the history
  • Loading branch information
YuanTingHsieh committed Aug 30, 2024
1 parent 1585713 commit 53d30dd
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions nvflare/app_common/workflows/cross_site_eval.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,6 @@ def _receive_val_result_cb(self, model: FLModel):
self.info(f"Saved validation result from client '{client_name}' on model '{model_owner}' in {file_path}")

def track_results(self, model_owner, data_client, val_results: FLModel):
self.info(f"track_results is called with {model_owner=} {data_client=} {val_results.metrics=}")
if not model_owner:
self.error("model_owner unknown. Validation result will not be saved to json")
if not data_client:
Expand All @@ -188,7 +187,6 @@ def track_results(self, model_owner, data_client, val_results: FLModel):
if data_client not in self._json_val_results:
self._json_val_results[data_client] = {}
self._json_val_results[data_client][model_owner] = val_results.metrics
self.info(f"track_results {self._json_val_results=}")

except Exception:
self.exception("Exception in handling validation result.")
Expand All @@ -204,5 +202,3 @@ def save_results(self):
self.info(f"saving validation result {self._json_val_results} to {res_file_path}")
with open(res_file_path, "w") as f:
f.write(json.dumps(self._json_val_results, indent=2))
with open("/tmp/nvflare/ppopamp.json", "w") as f:
f.write(json.dumps(self._json_val_results, indent=2))

0 comments on commit 53d30dd

Please sign in to comment.