DataBus #2285
Merged
DataBus #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chesterxgchen
force-pushed
the
message_bus
branch
from
e629251
to
35c4c3a
Compare
chesterxgchen
requested review from
yhwen,
YuanTingHsieh,
SYangster,
yanchengnv and
nvidianz
6 tasks
yanchengnv
requested changes
Jan 16, 2024
chesterxgchen
force-pushed
the
message_bus
branch
from
b00a12e
to
067acae
Compare
chesterxgchen
force-pushed
the
message_bus
branch
2 times, most recently
from
a70904b
to
e880033
Compare
yanchengnv
requested changes
Jan 24, 2024
chesterxgchen
force-pushed
the
message_bus
branch
from
343984a
to
c7b5297
Compare
|
/build |
yanchengnv
requested changes
Feb 5, 2024
address PR comments formatting
* check invalid input directory * check invalid input directory add doc string add doc string rename receive_messages() to receive_message() change doc str to google doc string style rebase and formats
1) remove data store scope/topic 2) add pub_sub interface and let databus implements the inferface 3) remove function_utils.py and unit tests for another PR
1) remove data store scope/topic 2) add pub_sub interface and let databus implements the inferface 3) remove function_utils.py and unit tests for another PR
chesterxgchen
force-pushed
the
message_bus
branch
from
a0a1e06
to
6e03a03
Compare
|
/build |
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the series PRs related to In-Process Client API Executor and WFCommAPI. This is the 1st PR for common utiliies
MessageBus is an singleton message store and publish (callbacks) structure that other can subscribe (callbacks) and receive message in callback when message is published. The event Manager can be built on top of messagebus.
The message can also send to/receive from message store for given topic.
The messagebus allows two components from strong coupling to loose coupling. For example, instead comp1 set a proprty directly on comp2. We can use messagebus, where comp1 send a message to messagebus, the comp2 receive the message from messagebus. comp2 is unaware who send the message and comp1 is unware who received the message.
Types of changes
./runtest.sh.