Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] address vdr feedback #2299

Merged
merged 3 commits into from
Jan 23, 2024
Merged

[2.4] address vdr feedback #2299

merged 3 commits into from
Jan 23, 2024

Conversation

SYangster
Copy link
Collaborator

For 2.4, same as #2297

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh
Copy link
Collaborator

needs to merge #2304 first

YuanTingHsieh
YuanTingHsieh approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SYangster SYangster merged commit 1d23ffc into NVIDIA:2.4 Jan 23, 2024
14 checks passed
@SYangster SYangster deleted the vdr_improvements_2.4 branch January 23, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SYangster @YuanTingHsieh