Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update execution api documentation and docstrings #2305

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Update execution api documentation and docstrings #2305

merged 2 commits into from
Jan 23, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented Jan 23, 2024 •
edited
Loading

Description

main branch version of PR

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh
[2.4] Update documentation and docstrings (NVIDIA#2300)
cc6b9f6 
* Update documentation and docstrings based on VDR feedbacks

* Address VDR issues regarding Client API and 3rd party integration docs and docstrings

* Fix unit test issue

* Address comments
@YuanTingHsieh
Rename task_execution to execution_api_type
429720e
@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh mentioned this pull request Jan 23, 2024
Merged
6 tasks
SYangster
SYangster approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@SYangster SYangster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh YuanTingHsieh merged commit d88fbdd into NVIDIA:main Jan 23, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the update_documentation_vdr branch January 23, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SYangster SYangster SYangster approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@yhwen yhwen Awaiting requested review from yhwen

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

@nvidianz nvidianz Awaiting requested review from nvidianz

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanTingHsieh @SYangster