Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up FilePipe remains #2369

Merged
merged 3 commits into from
Feb 24, 2024
Merged

Clean up FilePipe remains #2369

merged 3 commits into from
Feb 24, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

FilePipe will create folders for communication if needed.
We need to get rid of those folders so it will not confuses users.

Description

  • Remove the created folder

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh added the enhancement New feature or request label Feb 17, 2024
@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit 8312bc9 into NVIDIA:main Feb 24, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the clean_up_file_pipe branch February 24, 2024 04:16
@YuanTingHsieh YuanTingHsieh mentioned this pull request Mar 7, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanTingHsieh @chesterxgchen