Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Responder functions #2397

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Support Responder functions #2397

merged 6 commits into from
Mar 19, 2024

Conversation

SYangster
Copy link
Collaborator

@SYangster SYangster commented Mar 12, 2024 •
edited
Loading

  • fixes for integration pipeline issues
  • add events for handle_dead_job() and process_result_of_unknown_task
  • change multicast_and_wait to use standing tasks
  • combine initialize and start_controller

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@SYangster
Copy link
Collaborator Author

/build

YuanTingHsieh
YuanTingHsieh reviewed Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions

nvflare/apis/wf_comm_spec.py Outdated Show resolved Hide resolved
nvflare/apis/controller_spec.py Outdated Show resolved Hide resolved
nvflare/apis/impl/wf_comm_server.py Show resolved Hide resolved
@YuanTingHsieh
Copy link
Collaborator

@yanchengnv @chesterxgchen @holgerroth

After this effort of re-factoring controller,
I think we might need to re-evaluate the following classes, and try to simplify them or merge them:

yanchengnv
yanchengnv requested changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need wait_for_task. Let's discuss.

nvflare/apis/controller_spec.py Outdated Show resolved Hide resolved
nvflare/apis/wf_comm_spec.py Outdated Show resolved Hide resolved
nvflare/apis/controller_spec.py Outdated Show resolved Hide resolved
tests/unit_test/apis/impl/controller_test.py Outdated Show resolved Hide resolved
YuanTingHsieh
YuanTingHsieh reviewed Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

nvflare/app_common/workflows/cyclic_ctl.py Show resolved Hide resolved
tests/unit_test/apis/impl/controller_test.py Outdated Show resolved Hide resolved
nvflare/apis/impl/controller.py Outdated Show resolved Hide resolved
YuanTingHsieh
YuanTingHsieh previously approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SYangster
Copy link
Collaborator Author

/build

yanchengnv
yanchengnv requested changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

nvflare/apis/impl/controller.py Outdated Show resolved Hide resolved
nvflare/app_common/workflows/broadcast_operator.py Outdated Show resolved Hide resolved
nvflare/app_common/workflows/cyclic_ctl.py Outdated Show resolved Hide resolved
nvflare/app_common/workflows/cyclic_ctl.py Show resolved Hide resolved
@YuanTingHsieh YuanTingHsieh mentioned this pull request Mar 18, 2024
Merged
6 tasks
yanchengnv
yanchengnv requested changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see why you need to change GET_STATS to SET_STATS.
You changed on place to remove self.fl_ctx. In general, self.fl_ctx should never be used.

nvflare/apis/impl/wf_comm_server.py Outdated Show resolved Hide resolved
nvflare/app_common/psi/dh_psi/dh_psi_workflow.py Show resolved Hide resolved
nvflare/private/fed/client/client_runner.py Outdated Show resolved Hide resolved
nvflare/widgets/info_collector.py Outdated Show resolved Hide resolved
yanchengnv
yanchengnv requested changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment about GET_STATS. No need for SET_STATS.

nvflare/apis/impl/wf_comm_server.py Outdated Show resolved Hide resolved
yanchengnv
yanchengnv approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh YuanTingHsieh merged commit 2d3b42d into NVIDIA:main Mar 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanchengnv yanchengnv yanchengnv approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SYangster @YuanTingHsieh @chesterxgchen @yanchengnv