Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Add client api integration tests #2503

Merged
merged 5 commits into from
Apr 16, 2024
Merged

[2.4] Add client api integration tests #2503

merged 5 commits into from
Apr 16, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

  • Adds test stage client_api and client_api_qa
  • Adds corresponding test jobs

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh added the cicd continuous integration/continuous development label Apr 15, 2024
@YuanTingHsieh
Copy link
Collaborator Author

/build

chesterxgchen
chesterxgchen reviewed Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's those qa_job_xxxx, are those added by accidents

@YuanTingHsieh
Copy link
Collaborator Author

They are intended, Are you suggesting I change them to longer names to reflect what they are?

For example
"swarm_cse_pt_with_xxx"

@YuanTingHsieh
Copy link
Collaborator Author

/build

SYangster
SYangster approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@SYangster SYangster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qa_job_xxx can be renamed if it makes sense, otherwise LGTM

@YuanTingHsieh
Copy link
Collaborator Author

thanks, let me rename them later

@YuanTingHsieh YuanTingHsieh merged commit 08ac13f into NVIDIA:2.4 Apr 16, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the add_client_api_tests_24 branch April 16, 2024 19:51
@YuanTingHsieh YuanTingHsieh mentioned this pull request Apr 18, 2024
Merged
6 tasks
This was referenced Apr 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SYangster SYangster SYangster approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@yhwen yhwen Awaiting requested review from yhwen

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

Assignees
No one assigned
Labels
cicd continuous integration/continuous development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuanTingHsieh @chesterxgchen @SYangster