Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update client status #2508

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Fix update client status #2508

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
639d298
check workflow id before updating client status
SYangster Apr 15, 2024
e40caa9
change order of checks
SYangster Apr 16, 2024
3554531
Merge branch 'main' into fix_update_client_status
SYangster Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions nvflare/app_common/ccwf/server_ctl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,9 +440,6 @@ def _update_client_status(self, fl_ctx: FLContext):
peer_ctx = fl_ctx.get_peer_context()
assert isinstance(peer_ctx, FLContext)
client_name = peer_ctx.get_identity_name()
if client_name not in self.client_statuses:
self.log_error(fl_ctx, f"received result from unknown client {client_name}!")
return

# see whether status is available
reports = peer_ctx.get_prop(Constant.STATUS_REPORTS)
Expand All @@ -454,6 +451,10 @@ def _update_client_status(self, fl_ctx: FLContext):
if not my_report:
return

if client_name not in self.client_statuses:
self.log_error(fl_ctx, f"received result from unknown client {client_name}!")
return

report = status_report_from_dict(my_report)
cs = self.client_statuses[client_name]
assert isinstance(cs, ClientStatus)
Expand Down
Loading