Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cyclic WFController #2554

Merged
merged 2 commits into from
May 16, 2024
Merged

Add Cyclic WFController #2554

merged 2 commits into from
May 16, 2024

Conversation

SYangster
Copy link
Collaborator

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

ZiyueXu77
ZiyueXu77 reviewed May 16, 2024
View reviewed changes
Copy link
Collaborator

@ZiyueXu77 ZiyueXu77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Good move on the sample_clients function

holgerroth
holgerroth previously approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@holgerroth holgerroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SYangster SYangster requested a review from holgerroth May 16, 2024 16:47
@SYangster
Copy link
Collaborator Author

/build

@SYangster SYangster merged commit 87ab402 into NVIDIA:main May 16, 2024
16 checks passed
@SYangster SYangster deleted the cyclic_wf branch May 16, 2024 18:38
nvidianz pushed a commit to nvidianz/NVFlare that referenced this pull request May 22, 2024
@SYangster @nvidianz
add cyclic wfcontroller (NVIDIA#2554)
b11febd
nvidianz pushed a commit to nvidianz/NVFlare that referenced this pull request Jul 8, 2024
@SYangster @nvidianz
add cyclic wfcontroller (NVIDIA#2554)
c261c3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZiyueXu77 ZiyueXu77 ZiyueXu77 left review comments

@holgerroth holgerroth holgerroth approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SYangster @holgerroth @ZiyueXu77