Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow absolute path for the external script #2565

Merged
merged 9 commits into from
Jun 6, 2024
Merged

allow absolute path for the external script #2565

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
566ac5b
add check not allow absolute path for the external script in job crea…
yhwen May 7, 2024
6701949
Changed the job creation API to allow absolution path ext_scripts, bu…
yhwen May 7, 2024
ccfeddc
Added absolute path ext_script support for job creation.
yhwen May 9, 2024
2a71c61
removed the no use import.
yhwen May 9, 2024
5303507
Added handle for the line continous support, added unit test.
yhwen May 23, 2024
768411b
Merge branch 'main' into no_absolute_ext_script
yhwen May 23, 2024
65122dc
Removed the requirement for absolute external script to have the pack…
yhwen May 23, 2024
cd7f261
enhance the handling of multi-lines import. added more cases of unit …
yhwen May 30, 2024
cdd3916
Merge branch 'main' into no_absolute_ext_script
YuanTingHsieh Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions nvflare/job_config/base_app_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ def add_ext_script(self, ext_script: str):
if not os.path.exists(ext_script):
raise RuntimeError(f"Could not locate external script: {ext_script}")

if os.path.isabs(ext_script):
yhwen marked this conversation as resolved.
Show resolved Hide resolved
raise RuntimeError(f"External script: {ext_script} can not be absolute path.")

if not ext_script.endswith(".py"):
raise RuntimeError(f"External script: {ext_script} must be a '.py' file.")

Expand Down
Loading