Missing sj heartbeat #2583
Merged
Missing sj heartbeat #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanchengnv
reviewed
May 16, 2024
yanchengnv
reviewed
May 16, 2024
yanchengnv
requested changes
May 16, 2024
YuanTingHsieh
approved these changes
May 28, 2024
|
/build |
nvidianz
pushed a commit
to nvidianz/NVFlare
that referenced
this pull request
Jul 8, 2024
* Added the missing SJ heartbeat, fixed the early abort_job command issue. * codestyle fix. * Removed the no use constant. * Refactored. --------- Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <yuantingh@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
Add the missing SJ heartbeat calls to the parent. Add the logic to abort the job if it's not supposed to be running.
Types of changes
./runtest.sh.