Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed TaskScriptRunner which may locate the wrong script #2626

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

yhwen
Copy link
Collaborator

@yhwen yhwen commented Jun 10, 2024

Fixes # .

Description

Fixed several issues with the TaskScriptRunner:

  • Instead of using the site_name for searching the script on the site, change to use the custom_dir from the site workspace.
  • searching the script under the custom_dir, instead of the os.getcwd(), otherwise it may locate the script from a different job;
  • Change the unit tests to enable running the unit tests from different sub-folders, otherwise the unit tests can only be run from the NVFlare root folder.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chesterxgchen
Copy link
Collaborator

/build

@chesterxgchen
Copy link
Collaborator

/build

@chesterxgchen chesterxgchen merged commit e53cc17 into NVIDIA:main Jul 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants