Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the ScatterAndGather default persistor_id #2664

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Change the ScatterAndGather default persistor_id #2664

merged 4 commits into from
Jun 26, 2024

Conversation

yhwen
Copy link
Collaborator

@yhwen yhwen commented Jun 25, 2024

Fixes # .

Description

Changed the ScatterAndGather default persistor_id value from "" to "persistor".

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

yanchengnv
yanchengnv requested changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is a safe change. See my comments.

nvflare/app_common/workflows/scatter_and_gather.py Outdated Show resolved Hide resolved
@yhwen
Copy link
Collaborator Author

yhwen commented Jun 25, 2024

Not sure this is a safe change. See my comments.

changed the docstring of persistor_id in ScatterAndGather to default to empty string. Made this to match the "persistor_id" parameter definition.

chesterxgchen
chesterxgchen reviewed Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make comment

yanchengnv
yanchengnv approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhwen yhwen merged commit e9cf98e into NVIDIA:main Jun 26, 2024
15 checks passed
nvidianz pushed a commit to nvidianz/NVFlare that referenced this pull request Jul 8, 2024
@yhwen @chesterxgchen @nvidianz
Change the ScatterAndGather default persistor_id (NVIDIA#2664)
8bbda57 
* Changed the persistor_id for ScatterAndGather to persistor.

* changed the docstring of persistor_id in ScatterAndGather to default to empty string.

---------

Co-authored-by: Chester Chen <512707+chesterxgchen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@yanchengnv yanchengnv yanchengnv approved these changes

@holgerroth holgerroth Awaiting requested review from holgerroth

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yhwen @chesterxgchen @yanchengnv