Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Secure XGBoost Documentation #2671

Merged
merged 6 commits into from
Jul 1, 2024
Merged

[2.4] Secure XGBoost Documentation #2671

merged 6 commits into from
Jul 1, 2024

Conversation

SYangster
Copy link
Collaborator

  • secure xgboost user guide
  • secure xgboost design
  • experiment tracking apis

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

YuanTingHsieh
YuanTingHsieh reviewed Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, added some comments.

docs/programming_guide/experiment_tracking/experiment_tracking_apis.rst Show resolved Hide resolved
docs/programming_guide/experiment_tracking/experiment_tracking_apis.rst Outdated Show resolved Hide resolved
docs/programming_guide/experiment_tracking/experiment_tracking_apis.rst Outdated Show resolved Hide resolved
docs/programming_guide/experiment_tracking/experiment_tracking_log_writer.rst Outdated Show resolved Hide resolved
docs/programming_guide/experiment_tracking/experiment_tracking_log_writer.rst Outdated Show resolved Hide resolved
docs/programming_guide/experiment_tracking/experiment_tracking_log_writer.rst Outdated Show resolved Hide resolved
docs/user_guide/federated_xgboost/secure_xgboost_user_guide.rst Outdated Show resolved Hide resolved
docs/user_guide/federated_xgboost/secure_xgboost_user_guide.rst Outdated Show resolved Hide resolved
YuanTingHsieh
YuanTingHsieh reviewed Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.
Added more information please try to write them in good English ( as my sentences might be too "raw")
Thanks

docs/programming_guide/experiment_tracking/experiment_tracking_apis.rst Show resolved Hide resolved
docs/user_guide/federated_xgboost/secure_xgboost_user_guide.rst Outdated Show resolved Hide resolved
docs/user_guide/federated_xgboost/secure_xgboost_user_guide.rst Outdated Show resolved Hide resolved
chesterxgchen
chesterxgchen approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SYangster
Copy link
Collaborator Author

/build

@SYangster SYangster merged commit da3c4ac into NVIDIA:2.4 Jul 1, 2024
16 checks passed
SYangster added a commit to SYangster/NVFlare that referenced this pull request Aug 5, 2024
@SYangster @chesterxgchen
[2.4] Secure XGBoost Documentation (NVIDIA#2671)
8cae824 
* add 2.4.2 documentation

* update plugin configuration section

* address comments

* address comments 2

* change default plugin to cuda_paillier

---------

Co-authored-by: Chester Chen <512707+chesterxgchen@users.noreply.github.com>
@SYangster SYangster mentioned this pull request Aug 5, 2024
Merged
6 tasks
SYangster added a commit that referenced this pull request Aug 5, 2024
@SYangster @chesterxgchen
[2.4] Secure XGBoost Documentation (#2671) (#2759)
f81f922 
* add 2.4.2 documentation

* update plugin configuration section

* address comments

* address comments 2

* change default plugin to cuda_paillier

---------

Co-authored-by: Chester Chen <512707+chesterxgchen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh left review comments

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@nvidianz nvidianz Awaiting requested review from nvidianz

@yanchengnv yanchengnv Awaiting requested review from yanchengnv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SYangster @chesterxgchen @YuanTingHsieh @nvidianz