Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add correct params exchange format for tf #2676

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Add correct params exchange format for tf #2676

merged 1 commit into from
Jun 28, 2024

Conversation

SYangster
Copy link
Collaborator

@SYangster SYangster commented Jun 28, 2024 •
edited
Loading

Fixes #2040

default params exchange format is pytorch, need to change for tensorflow

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@SYangster SYangster requested a review from yhwen June 28, 2024 00:27
YuanTingHsieh
YuanTingHsieh approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@YuanTingHsieh
Copy link
Collaborator

/build

@SYangster SYangster merged commit 5af986a into NVIDIA:main Jun 28, 2024
16 checks passed
nvidianz pushed a commit to nvidianz/NVFlare that referenced this pull request Jul 8, 2024
@SYangster @nvidianz
add correct params exchange format for tf script executor (NVIDIA#2676)
08dd2a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@yhwen yhwen Awaiting requested review from yhwen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SYangster @YuanTingHsieh