Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CrossSiteEval with ModelController #2699

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Add CrossSiteEval with ModelController #2699

merged 4 commits into from
Jul 19, 2024

Conversation

SYangster
Copy link
Collaborator

Updated CSE workflow for recent ModelController changes.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

YuanTingHsieh
YuanTingHsieh approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh
Copy link
Collaborator

/build

@SYangster
Copy link
Collaborator Author

/build

@SYangster SYangster merged commit 92d87b7 into NVIDIA:main Jul 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@holgerroth holgerroth Awaiting requested review from holgerroth

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

@ZiyueXu77 ZiyueXu77 Awaiting requested review from ZiyueXu77

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SYangster @YuanTingHsieh