Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ModelController documentation #2707

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Add ModelController documentation #2707

merged 5 commits into from
Jul 30, 2024

Conversation

SYangster
Copy link
Collaborator

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

chesterxgchen
chesterxgchen reviewed Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small changes

YuanTingHsieh
YuanTingHsieh reviewed Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good, some comments

docs/programming_guide/controllers/model_controller.rst Outdated Show resolved Hide resolved
docs/programming_guide/controllers/model_controller.rst Outdated Show resolved Hide resolved
docs/programming_guide/controllers/model_controller.rst Outdated Show resolved Hide resolved
@SYangster
Copy link
Collaborator Author

/build

@SYangster
Copy link
Collaborator Author

/build

YuanTingHsieh
YuanTingHsieh approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@YuanTingHsieh
Copy link
Collaborator

/build

@SYangster SYangster merged commit aa04a12 into NVIDIA:main Jul 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen left review comments

@ZiyueXu77 ZiyueXu77 ZiyueXu77 left review comments

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SYangster @YuanTingHsieh @chesterxgchen @ZiyueXu77