-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support same app for all sites in Job API #2714
Conversation
/build |
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly good, added some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the method naming for now. Need documentations to explain the usage.
@YuanTingHsieh addressed your comments. |
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks LGTM
Fixes # .
Description
Introduces
to_server()
andto_clients()
routines to support defining the same app for all sites in Job API.Adds
n_clients
option tojob.simulator_run()
to still be able to define number of clients for simulation.Types of changes
./runtest.sh
.