Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance CLI command config #2716

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Conversation

YuanTingHsieh
Copy link
Collaborator

If users type "nvflare config" without entering any information, the old code will just raise an Exception and users see only:

"raise ValueError(f"job_templates_dir='{args.job_templates_dir}', it is not a directory")"

Add a new behavior so if specified nothing, users can check where the file is, and what is the current content of that hidden file.
If any directory is specified, the behavior is the same as before.

Description

  • Add print_hidden_config
  • Reuse methods from nvflare/utils/cli_utils.py

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit e623cf5 into NVIDIA:main Jul 19, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the enhance_cli branch July 19, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants