XGBoost plugin with new API #2725

nvidianz · 2024-07-23T02:13:10Z

Description

Rewrote the plugin with new XGBoost plugin API in 2.2.
Added LocalPlugin so GPU support can be ported with minimal code changes.
Implemented pass-thru plugin for non-secure training.

Types of changes

Non-breaking change (fix or new feature that would not break existing functionality).
Breaking change (fix or new feature that would cause existing functionality to change).
New tests added to cover the changes.
Quick tests passed locally by running ./runtest.sh.
In-line docstrings updated.
Documentation updated.

nvflare/app_opt/xgboost/histogram_based_v2/proto/federated_pb2.py

nvflare/app_opt/xgboost/histogram_based_v2/defs.py

integration/xgboost/encryption_plugins/src/include/base_plugin.h

nvflare/app_opt/xgboost/histogram_based_v2/runners/xgb_client_runner.py

YuanTingHsieh

Mostly LGTM, minor questions

nvflare/app_opt/xgboost/histogram_based_v2/sec/client_handler.py

integration/xgboost/encryption_plugins/src/include/base_plugin.h

YuanTingHsieh

LGTM

YuanTingHsieh · 2024-08-02T20:57:44Z

/build

nvidianz and others added 27 commits March 18, 2024 15:46

Updated FOBS readme to add DatumManager, added agrpcs as secure scheme

a655d9d

Merge branch 'NVIDIA:main' into main

4e5ba5d

Merge branch 'NVIDIA:main' into main

9f90d48

Merge branch 'NVIDIA:main' into main

84fc5bd

Merge branch 'NVIDIA:main' into main

f972506

Merge branch 'NVIDIA:main' into main

5f6e76f

Merge branch 'NVIDIA:main' into main

15884c4

Merge branch 'NVIDIA:main' into main

6fbcbaa

Merge branch 'NVIDIA:main' into main

07d3787

Merge branch 'NVIDIA:main' into main

98289c4

Merge branch 'NVIDIA:main' into main

cb8cdef

Merge branch 'NVIDIA:main' into main

47facb8

Merge branch 'NVIDIA:main' into main

cdb4b92

Merge branch 'NVIDIA:main' into main

a194f6d

Merge branch 'NVIDIA:main' into main

79c955e

Merge branch 'NVIDIA:main' into main

b8d5f56

Merge branch 'NVIDIA:main' into main

f6f6dbc

Merge branch 'NVIDIA:main' into main

e0732cc

Merge branch 'NVIDIA:main' into main

f77c56b

Merge branch 'NVIDIA:main' into main

5c43908

Merge branch 'NVIDIA:main' into main

f5496b3

Merge branch 'NVIDIA:main' into main

3fdb95b

Merge branch 'NVIDIA:main' into main

654bc17

Merge branch 'NVIDIA:main' into main

c721e0e

Merge branch 'NVIDIA:main' into main

517ad90

Merge branch 'NVIDIA:main' into main

7c66bd2

Implemented LocalPlugin

d0b51c1

nvidianz requested review from chesterxgchen, YuanTingHsieh and SYangster July 23, 2024 02:13

nvidianz requested review from yanchengnv and ZiyueXu77 July 23, 2024 02:13

nvidianz added 2 commits July 25, 2024 17:04

Refactoring plugin

43610ee

Fixed formats

729ae37

YuanTingHsieh reviewed Jul 26, 2024

View reviewed changes

nvflare/app_opt/xgboost/histogram_based_v2/proto/federated_pb2.py Outdated Show resolved Hide resolved

YuanTingHsieh reviewed Jul 26, 2024

View reviewed changes

nvflare/app_opt/xgboost/histogram_based_v2/defs.py Show resolved Hide resolved

YuanTingHsieh reviewed Jul 26, 2024

View reviewed changes

integration/xgboost/encryption_plugins/src/include/base_plugin.h Outdated Show resolved Hide resolved

YuanTingHsieh reviewed Jul 26, 2024

View reviewed changes

nvflare/app_opt/xgboost/histogram_based_v2/runners/xgb_client_runner.py Show resolved Hide resolved

nvidianz and others added 7 commits July 26, 2024 04:18

Fixed horizontal secure isses with mismatching algather-v sizes

1133cfc

Added padding to the buffer so it's big enough for histograms

9c5d8f6

Format fix

b6641c8

Merge branch 'main' into xgboost-plugin-new-api

6b48d51

Merge branch 'main' into xgboost-plugin-new-api

35f0a92

Changed log level for tenseal exceptions

f3e32ac

Fixed a typo

9736bbf

YuanTingHsieh reviewed Aug 1, 2024

View reviewed changes

nvflare/app_opt/xgboost/histogram_based_v2/sec/client_handler.py Show resolved Hide resolved

nvidianz added 4 commits August 2, 2024 10:23

Added debug statements

3943313

Fixed LocalPlugin horizontal bug

e2283e4

Added #include <chrono>

df7cb0f

Added docstring to BasePlugin

7acccb4

YuanTingHsieh reviewed Aug 2, 2024

View reviewed changes

integration/xgboost/encryption_plugins/src/include/base_plugin.h Show resolved Hide resolved

YuanTingHsieh approved these changes Aug 2, 2024

View reviewed changes

Merge branch 'main' into xgboost-plugin-new-api

9d960b9

nvidianz merged commit 45a16d5 into NVIDIA:main Aug 2, 2024
15 of 16 checks passed

nvidianz deleted the xgboost-plugin-new-api branch August 2, 2024 21:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XGBoost plugin with new API #2725

XGBoost plugin with new API #2725

nvidianz commented Jul 23, 2024

YuanTingHsieh left a comment

YuanTingHsieh left a comment

YuanTingHsieh commented Aug 2, 2024

XGBoost plugin with new API #2725

XGBoost plugin with new API #2725

Conversation

nvidianz commented Jul 23, 2024

Description

Types of changes

YuanTingHsieh left a comment

Choose a reason for hiding this comment

YuanTingHsieh left a comment

Choose a reason for hiding this comment

YuanTingHsieh commented Aug 2, 2024