Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update xgboost user guide #2750

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Update xgboost user guide #2750

merged 4 commits into from
Aug 7, 2024

Conversation

SYangster
Copy link
Collaborator

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@SYangster SYangster requested a review from nvidianz July 31, 2024 23:01
@SYangster SYangster force-pushed the xgb_guide_updates branch 2 times, most recently from 54ecc51 to 8105e6c Compare August 1, 2024 17:03
YuanTingHsieh
YuanTingHsieh reviewed Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

docs/user_guide/federated_xgboost/secure_xgboost_user_guide.rst Outdated Show resolved Hide resolved
examples/advanced/xgboost/histogram-based/README.md Outdated Show resolved Hide resolved
@YuanTingHsieh YuanTingHsieh changed the title Update xgboost user guide [2.4] Update xgboost user guide Aug 2, 2024
@SYangster
Copy link
Collaborator Author

/build

@chesterxgchen chesterxgchen changed the title [2.4] Update xgboost user guide [2.5] Update xgboost user guide Aug 4, 2024
@chesterxgchen chesterxgchen changed the title [2.5] Update xgboost user guide [2.4] Update xgboost user guide Aug 4, 2024
@chesterxgchen
Copy link
Collaborator

@SYangster this needs to go main branch

@SYangster SYangster changed the title [2.4] Update xgboost user guide Update xgboost user guide Aug 5, 2024
@SYangster SYangster changed the base branch from 2.4 to main August 5, 2024 22:17
@SYangster SYangster changed the base branch from main to 2.4 August 5, 2024 22:17
@SYangster SYangster changed the base branch from 2.4 to main August 5, 2024 23:10
@SYangster
Copy link
Collaborator Author

/build

YuanTingHsieh
YuanTingHsieh approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh YuanTingHsieh added the documentation Improvements or additions to documentation label Aug 7, 2024
@YuanTingHsieh
Copy link
Collaborator

/build

1 similar comment
@YuanTingHsieh
Copy link
Collaborator

/build

@SYangster SYangster merged commit 4c6d19d into NVIDIA:main Aug 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen left review comments

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@nvidianz nvidianz Awaiting requested review from nvidianz

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SYangster @chesterxgchen @YuanTingHsieh