Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix for instructions in setup_poc.ipynb for main #2752

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

hwpang
Copy link
Contributor

@hwpang hwpang commented Aug 1, 2024

Description

Minor fix for instructions in setup_poc.ipynb in the examples/tutorials folder.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh
Copy link
Collaborator

@hwpang looks good, please rebase (squash) and sign your commit thanks

Add job templates arg

to avoid "Unable to handle command: config due to: job_templates_dir='None', it is not a directory" error

Use full name
@hwpang
Copy link
Contributor Author

hwpang commented Aug 2, 2024

@YuanTingHsieh Thanks, I have rebased and squashed, and signed my commit.

@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh YuanTingHsieh added the documentation Improvements or additions to documentation label Aug 2, 2024
@YuanTingHsieh YuanTingHsieh merged commit 5c63229 into NVIDIA:main Aug 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants