Ignore TenSeal errors if not secure horizontal training #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvidianz
requested review from
chesterxgchen,
yhwen,
YuanTingHsieh and
yanchengnv
|
let's wait for #2773 and resolve conflicts after |
YuanTingHsieh
requested changes
Aug 9, 2024
| @@ -173,7 +173,7 @@ def stop_task(self, task: RxTask, error: StreamError = None, notify=True): | |||
|
|
|||
| if error: | |||
| if task.headers: | |||
| optional = task.headers.get(MessageHeaderKey.OPTIONAL, False) | |||
| optional = task.headers.get(StreamHeaderKey.OPTIONAL, False) | |||
There was a problem hiding this comment.
Why do we need to change this
Comment on lines
+34
to
+37
| if ipcl_imported: | ||
| return ipcl_python.PaillierKeypair.generate_keypair(n_length=n_length, enable_DJN=ENABLE_DJN) | ||
| else: | ||
| return None, None |
There was a problem hiding this comment.
I think we don't need this once the conflicts are resolved.
|
PR is based on the wrong version of xgboost. Will do another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FLARE-2152.
Description
Types of changes
./runtest.sh.